Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/tableau): fix node limit exceeded error for workbooks query #7068

Merged

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Jan 18, 2023

This is done by separating sheets/dashboards query from workbooks query.

Existing ingestion recipes that override default page_size: 10 to lesser value such as page_size: 1 may experience notable increase in ingestion time due to more api calls being made. The ingestion time can be reduced in this case by experimenting with page_size, either removing the config from recipe and setting it to higher value that does not give node limit error.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 18, 2023
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 4e7faa5 into datahub-project:master Jan 18, 2023
hsheth2 added a commit to hsheth2/datahub that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants