fix(frontend logs): Silencing harmless log messages (and adding path for future) #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-radhakrishnan
approved these changes
Feb 4, 2023
| @@ -10,6 +10,10 @@ | |||
| <filter class="ch.qos.logback.classic.filter.ThresholdFilter"> | |||
| <level>INFO</level> | |||
| </filter> | |||
| <filter class="log.LogMessageFilter"> | |||
There was a problem hiding this comment.
woah this is super cool
| /** | ||
| * A set of messages to exclude. | ||
| */ | ||
| private final List<String> excluded = new ArrayList<>(); |
There was a problem hiding this comment.
Nice so the <excluded> tag in the xml file just automatically fills this out?
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR I've introduced a custom logback filter that will accept partial log messages and filter them out on a case by case basis.
This is useful for hushing specific warnings or errors coming from the underlying libraries (like Pac4j) without having to silence them completely. (e.g. at class or package level).
We only silence in the stdout logger, but keep in the file appender for our debugging purposes.
Specific warnings which are hushed:
Status
Ready for review
Checklist