Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphql): Added GraphQL mappings for the "created" and "lastModified" fields in "DatasetProperties" aspect #7463

Merged
merged 4 commits into from Mar 8, 2023
Merged

feat(graphql): Added GraphQL mappings for the "created" and "lastModified" fields in "DatasetProperties" aspect #7463

merged 4 commits into from Mar 8, 2023
+188 −0

Conversation

siladitya2
Copy link
Contributor

@siladitya2 siladitya2 commented Mar 1, 2023 •
edited

Adding GraphQL mappings for the "created" and "lastModified" fields in "DatasetProperties" aspect

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Mar 1, 2023
aditya-radhakrishnan
aditya-radhakrishnan reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If we could add some tests, that would be amazing.

datahub-graphql-core/src/main/resources/entity.graphql Outdated Show resolved Hide resolved
datahub-graphql-core/src/main/resources/entity.graphql Outdated Show resolved Hide resolved
...hql-core/src/main/java/com/linkedin/datahub/graphql/types/dataset/mappers/DatasetMapper.java Show resolved Hide resolved
...hql-core/src/main/java/com/linkedin/datahub/graphql/types/dataset/mappers/DatasetMapper.java Show resolved Hide resolved
@aditya-radhakrishnan aditya-radhakrishnan added the community-contribution PR or Issue raised by member(s) of DataHub Community label Mar 2, 2023
aditya-radhakrishnan
aditya-radhakrishnan approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Will merge once CI is passing

datahub-graphql-core/src/main/resources/entity.graphql Show resolved Hide resolved
...core/src/test/java/com/linkedin/datahub/graphql/types/dataset/mappers/DatasetMapperTest.java Show resolved Hide resolved
@aditya-radhakrishnan
Copy link
Contributor

Looks like CI is still failing. Going to run it one more time but it may not be flakey. Hopefully there isn't a bug here

@siladitya2
Copy link
Contributor Author

CI looks good now.

@aditya-radhakrishnan aditya-radhakrishnan merged commit 3ce8af1 into datahub-project:master Mar 8, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siladitya2 @aditya-radhakrishnan