fix(ingest): remove get_platform_instance_id from stateful ingestion #7572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that it's been ~3 months since datahub-project#6795 was merged, we can finish the clean up.
github-actions
bot
added
the
ingestion
treff7es
reviewed
Mar 16, 2023
| ) | ||
| if last_checkpoint_aspect is None: |
There was a problem hiding this comment.
Isn't this a breaking change that should be documented?
There was a problem hiding this comment.
The only case in which this would break is if someone upgraded directly from a 3 month old version to latest, in which case we won't be able to fetch previous state from stateful ingestion
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
…atahub-project#7572) Co-authored-by: Tamas Nemeth <treff7es@gmail.com>
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
…atahub-project#7572) Co-authored-by: Tamas Nemeth <treff7es@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that it's been ~3 months since #6795 was merged, we can finish the clean up.
Checklist