One-by-one file insert to avoid transaction timeout when inserting large files#226
Merged
kushalbakshi merged 5 commits intoNov 5, 2025
Conversation
pull from upstream
kushalbakshi
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how result files are inserted into the database within the
element_array_ephys/spike_sorting/si_spike_sorting.pymodule. Instead of batch-inserting file records, the code now inserts each file individually as it is discovered. This change enhances clarity and may improve error handling or logging for individual file insertions.Refactoring of file insertion logic:
self.File.insert([...])) to per-file insertion (self.File.insert1(...)) for result files in the_run_sortermethod._sorting_analyzer_computemethod for files in the analyzer output directory._export_reportmethod to insert report files individually for each file found in the relevant report directories.