Skip to content

Conversation

@kushalbakshi
Copy link
Collaborator

@kushalbakshi kushalbakshi commented Aug 31, 2023

This PR adds the suggestions from #2 that were not included when that PR was merged.

To provide clarity on this comment from #2: when diameter is set to None, cellpose runs much quicker than if it is set to a specific value

@kushalbakshi kushalbakshi requested a review from kabilar August 31, 2023 16:47
@kushalbakshi kushalbakshi self-assigned this Aug 31, 2023
@kushalbakshi kushalbakshi linked an issue Aug 31, 2023 that may be closed by this pull request
@kabilar
Copy link
Collaborator

kabilar commented Aug 31, 2023

To provide clarity on this comment from #2: when diameter is set to None, cellpose runs much quicker than if it is set to a specific value

Thanks @kushalbakshi. It makes sense to set diameter=None. After further review of the documentation, the diameter is automatically estimated when it is set to None.

Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushalbakshi. All changes look good. Were you able to successfully run these tests locally?

Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@kushalbakshi
Copy link
Collaborator Author

Thanks @kushalbakshi. All changes look good. Were you able to successfully run these tests locally?

I have not run the tests locally yet. With the tutorial-db offline, I currently don't have access to an account that has permissions to create schemas.

@kabilar
Copy link
Collaborator

kabilar commented Sep 1, 2023

Thanks @kushalbakshi. All changes look good. Were you able to successfully run these tests locally?

I have not run the tests locally yet. With the tutorial-db offline, I currently don't have access to an account that has permissions to create schemas.

Let's hold off on merging until these tests have been run locally. Were you able to get permission to create schemas on db.datajoint.com?

@kabilar kabilar marked this pull request as draft September 1, 2023 15:39
@kushalbakshi
Copy link
Collaborator Author

Thanks @kushalbakshi. All changes look good. Were you able to successfully run these tests locally?

I have not run the tests locally yet. With the tutorial-db offline, I currently don't have access to an account that has permissions to create schemas.

Let's hold off on merging until these tests have been run locally. Were you able to get permission to create schemas on db.datajoint.com?

I'm in the process of setting one up. Instead of <username_> as the database prefix, in order to maintain consistency with the internal _ conventions, we're setting up a test workflow for the sciops team that will retain this structure and have permissions to create schemas

@kushalbakshi
Copy link
Collaborator Author

Here is the output of the pytest after the most recent changes:

image

@kushalbakshi kushalbakshi marked this pull request as ready for review September 19, 2023 18:51

## [0.1.1] - 2023-08-31

+ Update - Incorporate suggestions from previous PR to improve pytests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ Update - Incorporate suggestions from previous PR to improve pytests
+ Update - Improve pytests

@ttngu207 ttngu207 merged commit 13be4af into datajoint:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improvements to pytest suite

3 participants