-
Notifications
You must be signed in to change notification settings - Fork 3
Update pytests #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @kushalbakshi. It makes sense to set |
kabilar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kushalbakshi. All changes look good. Were you able to successfully run these tests locally?
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
I have not run the tests locally yet. With the |
Let's hold off on merging until these tests have been run locally. Were you able to get permission to create schemas on |
I'm in the process of setting one up. Instead of <username_> as the database prefix, in order to maintain consistency with the internal _ conventions, we're setting up a test workflow for the sciops team that will retain this structure and have permissions to create schemas |
|
|
||
| ## [0.1.1] - 2023-08-31 | ||
|
|
||
| + Update - Incorporate suggestions from previous PR to improve pytests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| + Update - Incorporate suggestions from previous PR to improve pytests | |
| + Update - Improve pytests |

This PR adds the suggestions from #2 that were not included when that PR was merged.
To provide clarity on this comment from #2: when
diameteris set toNone,cellposeruns much quicker than if it is set to a specific value