Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_add_archive_use_archive_dir() uses expression that is broken on windows #2534

Closed
mih opened this issue May 23, 2018 · 0 comments
Closed
Labels
fix-implemented A fix is available, but has not been merged or released, yet. platform-windows Issue concerned with Windows

Comments

@mih
Copy link
Member

mih commented May 23, 2018

[00:04:01] ======================================================================
[00:04:01] ERROR: datalad.interface.tests.test_add_archive_content.test_add_archive_use_archive_dir
[00:04:01] ----------------------------------------------------------------------
[00:04:01] Traceback (most recent call last):
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\nose\case.py", line 198, in runTest
[00:04:01]     self.test(*self.arg)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\utils.py", line 1138, in newfunc
[00:04:01]     reraise(*exc_info)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\six.py", line 693, in reraise
[00:04:01]     raise value
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\utils.py", line 1114, in newfunc
[00:04:01]     func(*args, **kwargs)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\utils.py", line 499, in newfunc
[00:04:01]     return t(*(arg + (d,)), **kw)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\interface\tests\test_add_archive_content.py", line 346, in test_add_archive_use_archive_dir
[00:04:01]     str(cmr.exception), match=False
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\utils.py", line 1176, in assert_re_in
[00:04:01]     if (re.match if match else re.search)(regex, e, flags=flags):
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\re.py", line 173, in search
[00:04:01]     return _compile(pattern, flags).search(string)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\re.py", line 293, in _compile
[00:04:01]     p = sre_compile.compile(pattern, flags)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\sre_compile.py", line 536, in compile
[00:04:01]     p = sre_parse.parse(p, flags)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\sre_parse.py", line 829, in parse
[00:04:01]     p = _parse_sub(source, pattern, 0)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\sre_parse.py", line 437, in _parse_sub
[00:04:01]     itemsappend(_parse(source, state))
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\sre_parse.py", line 524, in _parse
[00:04:01]     code = _escape(source, this, state)
[00:04:01]   File "C:\Miniconda35\envs\test-environment\lib\sre_parse.py", line 418, in _escape
[00:04:01]     raise source.error("invalid group reference", len(escape))
[00:04:01] sre_constants.error: invalid group reference at position 33
@mih mih added the platform-windows Issue concerned with Windows label May 23, 2018
@mih mih added the fix-implemented A fix is available, but has not been merged or released, yet. label Jan 11, 2020
@mih mih closed this as completed in 0ca376c Jan 12, 2020
mih added a commit that referenced this issue Jan 12, 2020
BF: Proper windows-compatible test expression (fixes gh-2534)
yarikoptic added a commit that referenced this issue Jan 16, 2020
Release 0.12.1

* tag '0.12.1':
  Release 0.12.1
  BF: clone: Revert incorrect relative path adjustment to URLs
  BF: Proper windows-compatible test expression (fixes gh-2534)
  TST: Make more tests run on appveyor
  BF: Properly handle directory separators on Windows (fixes gh-2566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-implemented A fix is available, but has not been merged or released, yet. platform-windows Issue concerned with Windows
Projects
None yet
Development

No branches or pull requests

1 participant