Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_files broken on Windows #2566

Closed
mih opened this issue May 27, 2018 · 1 comment
Closed

find_files broken on Windows #2566

mih opened this issue May 27, 2018 · 1 comment
Labels
fix-implemented A fix is available, but has not been merged or released, yet. platform-windows Issue concerned with Windows

Comments

@mih
Copy link
Member

mih commented May 27, 2018 

[00:15:30] ======================================================================
[00:15:30] FAIL: datalad.tests.test_utils.test_find_files
[00:15:30] ----------------------------------------------------------------------
[00:15:30] Traceback (most recent call last):
[00:15:30]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\nose\case.py", line 198, in runTest
[00:15:30]     self.test(*self.arg)
[00:15:30]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\test_utils.py", line 482, in test_find_files
[00:15:30]     assert_in(opj(tests_dir, 'test_utils.py'), files3)
[00:15:30] AssertionError: 'C:\\Miniconda35\\envs\\test-environment\\lib\\site-packages\\datalad\\tests\\test_utils.py' not found in []
[00:15:30] 
[00:15:30] ======================================================================
[00:15:30] FAIL: datalad.tests.test_utils.test_find_files_exclude_vcs
[00:15:30] ----------------------------------------------------------------------
[00:15:30] Traceback (most recent call last):
[00:15:30]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\nose\case.py", line 198, in runTest
[00:15:30]     self.test(*self.arg)
[00:15:30]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\utils.py", line 499, in newfunc
[00:15:30]     return t(*(arg + (d,)), **kw)
[00:15:30]   File "C:\Miniconda35\envs\test-environment\lib\site-packages\datalad\tests\test_utils.py", line 500, in test_find_files_exclude_vcs
[00:15:30]     assert_equal({basename(f) for f in files}, {'d1', 'git'})
[00:15:30] AssertionError: Items in the first set but not the second:
[00:15:30] '.git'
[00:15:30] '1'
@mih mih added the platform-windows Issue concerned with Windows label May 27, 2018
@mih
Copy link
Member Author

mih commented Jan 9, 2020

Still the case today.

@mih mih added the fix-implemented A fix is available, but has not been merged or released, yet. label Jan 11, 2020
@mih mih closed this as completed in b65a891 Jan 12, 2020
mih added a commit that referenced this issue Jan 12, 2020
@mih
Merge pull request #4013 from mih/bf-2566
67a3533 
BF: Properly handle directory separators on Windows (fixes gh-2566)
yarikoptic added a commit that referenced this issue Jan 16, 2020
@yarikoptic
Merge tag '0.12.1' into debian
def70a5 
Release 0.12.1

* tag '0.12.1':
  Release 0.12.1
  BF: clone: Revert incorrect relative path adjustment to URLs
  BF: Proper windows-compatible test expression (fixes gh-2534)
  TST: Make more tests run on appveyor
  BF: Properly handle directory separators on Windows (fixes gh-2566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix-implemented A fix is available, but has not been merged or released, yet. platform-windows Issue concerned with Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mih