Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch autoenabled special remote if it is a regular git remote #2897

Closed
yarikoptic opened this issue Oct 4, 2018 · 2 comments
Closed

fetch autoenabled special remote if it is a regular git remote #2897

yarikoptic opened this issue Oct 4, 2018 · 2 comments
Labels
severity-important major effect on the usability of a package, without rendering it completely unusable to everyone
Milestone
0.13.2

Comments

@yarikoptic
Copy link
Member

What is the problem?

ATM if we e.g. clone from github with another http git special remote autoenabled, we do enable it, but then we do not fetch it. If its git-annex branch is advanced forward from what we have pushed to github, local clone lacks that information. So I wondered if we should also fetch upon autoenable if that git remote (after enableremote) has a url field defined (AFAIK that is a sign that it is a regular git remote). What do you think?
@yarikoptic yarikoptic added the severity-important major effect on the usability of a package, without rendering it completely unusable to everyone label Jul 29, 2020
@yarikoptic
Copy link
Member Author

Oh hoh, we (well @chaselgrove) ran into it within ReproNim/containers#44 . We better have it resolved and it should be "easy". @kyleam would be you kind to have a look?

@yarikoptic yarikoptic modified the milestones: 0.13.x, 0.13.2 Jul 29, 2020
yarikoptic added a commit to ReproNim/containers that referenced this issue Jul 29, 2020
@yarikoptic
BF(DOC): use ///repronim/containers directly + provide complete scrip…
ed11dd5 
…t working in TMPDIR

original report: #44

Use /// since that is where we have all the images and there is a bug to be fixed on datalad
end: datalad/datalad#2897

With using TMPDIR and () we can make it cut/pasteable and/or script.  We could
possibly even automate testing of this snippet since it would be easy to
identify it in the README.md (might do later).  And set -eu  is a demonstration
of good practices we try to encourage in our training materials
kyleam added a commit to kyleam/datalad that referenced this issue Jul 29, 2020
@kyleam
BF: clone: Fetch autoenabled type=git special remotes
d86395c 
Otherwise `datalad get` fails to get content that is only in the
special remote and not known to the other remotes.

Fixes datalad#2897.
kyleam added a commit to kyleam/datalad that referenced this issue Jul 29, 2020
@kyleam
BF: clone: Fetch autoenabled type=git special remotes
29beeb3 
Otherwise `datalad get` fails to get content that is only in the
special remote and not known to the other remotes.

Fixes datalad#2897.
@kyleam kyleam mentioned this issue Jul 29, 2020
Merged
@kyleam
Copy link
Contributor

kyleam commented Jul 29, 2020

@kyleam would be you kind to have a look?

The original recipe from ReproNim/containers#44 fails on my end too and is resolved by #4783.

@kyleam kyleam closed this as completed in fb8563f Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity-important major effect on the usability of a package, without rendering it completely unusable to everyone
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
2 participants
@yarikoptic @kyleam