New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF+ENH: if search resulted in no hits due to wrong keys used, log an INFO msg with suggestions #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enting suggestions 'any' is used now instead of 'one' since we can query for multiple terms at once so 'one' really doesn't fit there, while 'any' fits both scenarios
…O msg with suggestions
Any objections/recommendations ? |
yarikoptic
added a commit
that referenced
this pull request
Feb 8, 2019
A variety of bugfixes and enhancements ### Major refactoring and deprecations - All extracted metadata is now placed under git-annex by default. Previously files smaller than 20 kb were stored in git. ([#3109]) - TODO: get_runner #3104 and pending #3131 ### Fixes - Improved handling of long commands: - The code that inspected `SC_ARG_MAX` didn't check that the reported value was a sensible, positive number. ([#3025]) - More commands that invoke `git` and `git-annex` with file arguments learned to split up the command calls when it is likely that the command would fail due to exceeding the maximum supported length. ([#3138]) - The `setup_yoda_dataset` procedure created a malformed .gitattributes line. ([#3057]) - [download-url] unnecessarily tried to infer the dataset when `--no-save` was given. ([#3029]) - [rerun] aborted too late and with a confusing message when a ref specified via `--onto` didn't exist. ([#3019]) - [run]: - `run` didn't preserve the current directory prefix ("./") on inputs and outputs, which is problematic if the caller relies on this representation when formatting the command. ([#3037]) - Fixed a number of unicode py2-compatibility issues. ([#3035]) ([#3046]) - To proceed with a failed command, the user was confusingly instructed to use `save` instead of `add` even though `run` uses `add` underneath. ([#3080]) - Fixed a case where the helper class for checking external modules incorrectly reported a module as unknown. ([#3051]) - [add-archive-content] mishandled the archive path when the leading path contained a symlink. ([#3058]) - Following denied access, the credential code failed to consider a scenario, leading to a type error rather than an appropriate error message. ([#3091]) - Some tests failed when executed from a `git worktree` checkout of the source repository. ([#3129]) - During metadata extraction, batched annex processes weren't properly terminated, leading to issues on Windows. ([#3137]) - [add] incorrectly handled an "invalid repository" exception when trying to add a submodule. ([#3141]) - Pass `GIT_SSH_VARIANT=ssh` to git processes to be able to specify alternative ports in SSH urls ### Enhancements and new features - [search] learned to suggest closely matching keys if there are no hits. ([#3089]) - [create-sibling] gained a `--group` option so that the caller can specify the file system group for the repository. ([#3098]) - Interface classes can now override the default renderer for summarizing results. ([#3061]) - [run]: - `--input` and `--output` can now be shortened to `-i` and `-o`. ([#3066]) - Placeholders such as "{inputs}" are now expanded in the command that is shown in the commit message subject. ([#3065]) - `interface.run.run_command` gained an `extra_inputs` argument so that wrappers like [datalad-container] can specify additional inputs that aren't considered when formatting the command string. ([#3038]) - "--" can now be used to separate options for `run` and those for the command in ambiguous cases. ([#3119]) - The utilities `create_tree` and `ok_file_has_content` now support ".gz" files. ([#3049]) - The Singularity container for 0.11.1 now uses [nd_freeze] to make its builds reproducible. - A [publications] page has been added to the documentation. ([#3099]) - `GitRepo.set_gitattributes` now accepts a `mode` argument that controls whether the .gitattributes file is appended to (default) or overwritten. ([#3115]) - `datalad --help` now avoids using `man` so that the list of subcommands is shown. ([#3124]) * tag '0.11.2': (124 commits) Changelog entry for GIT_SSH_VARIANT change ENH: Declare our GIT_SSH_COMMAND as GIT_SSH_VARIANT=ssh BF: sshconnector: Don't use ssh's port flag as scp's RF: sshconnector: Simplify shlex quote import CHANGELOG(0.11.2): Fix some typos [DATALAD RUNCMD] CHANGELOG: Linkify 0.11.2 entries CHANGELOG: Do first pass for 0.11.2 CHANGELOG: Add missing link target for download-url Start cooking the 0.11.2 release RF: appveyor - move test_install tests to be ran the last RF: text_type instead of str ENH(TST): provide my timing for the slow test BF(TST): adjust the test for the fact that AnnexRepo.add does not blow on nonexisting files ENH(TST): two tests which test quick or thorough for add failing with too long list of files BF: get stderr if present, otherwise just use str(e) BF: append out/err only if not empty/None Centrlize handling running commands with long files list in _run_command_files_split RF: remove minor duplication of -- handling, place all files handling closer to the call RF: move unrelated to try/except handling outside ENH+DOC: Report actual process handle, not just PID ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just kept hitting the situations where a key is mistyped and I get no results, and have no clue what went wrong - either there is no hits really or I mistyped something. Now would look like
not ideal, but at least gives clues