Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious INFO log message from search #3195

Closed
yarikoptic opened this issue Mar 5, 2019 · 3 comments
Closed

Mysterious INFO log message from search #3195

yarikoptic opened this issue Mar 5, 2019 · 3 comments
Labels
fix-implemented A fix is available, but has not been merged or released, yet.

Comments

@yarikoptic
Copy link
Member

(git)smaug:/mnt/btrfs/datasets/datalad/crawl/crcns[master]git
$> datalad --version
datalad 0.11.3

$> datalad search aaaaaa
[INFO   ]  

$> datalad search aaaaaa | cat
[INFO]  

@kyleam
Copy link
Contributor

kyleam commented Mar 14, 2019

I think you're the source of your own mystery: a66261a (ENH: if search resulted in no hits due to wrong keys used, log an INFO msg with suggestions, 2018-12-13)

if not nhits:
lgr.info(searcher.get_nohits_msg() or '')

Perhaps '' should be replaced with 'no hits'.

@yarikoptic
Copy link
Member Author

THANK YOU @kyleam for digging. Indeed, "no hits" would be the right thing to have. you/me?

@kyleam
Copy link
Contributor

kyleam commented Mar 14, 2019

I'll open a PR.

kyleam added a commit to kyleam/datalad that referenced this issue Mar 14, 2019
If get_nohits_msg() doesn't return a message, report a generic "no
hits" so that caller isn't left wondering what the blank message is
about.

Fixes datalad#3195.
@kyleam kyleam added the fix-implemented A fix is available, but has not been merged or released, yet. label Mar 20, 2019
@kyleam kyleam closed this as completed in 39aa93f Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-implemented A fix is available, but has not been merged or released, yet.
Projects
None yet
Development

No branches or pull requests

2 participants