Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSHConnection.copy() is actually copy_to_remote() #3401

Closed
mih opened this issue May 12, 2019 · 0 comments
Closed

SSHConnection.copy() is actually copy_to_remote() #3401

mih opened this issue May 12, 2019 · 0 comments

Comments

@mih
Copy link
Member

@mih mih commented May 12, 2019

It will only use the connection to copy things to the remote host, and not from it to the local host. Given the nature of the matter (there is an existing connection to a single remote host in SSHConnection) it makes sense to me to add a sibling method that does the same as copy() (prefix the remote paths with the connection host), but for the source files. This would also need a rename of copy() to something like copy_to_remote(), so that the new method becomes copy_from_remote().

mih added a commit to mih/datalad that referenced this issue May 13, 2019
mih added a commit to mih/datalad that referenced this issue May 15, 2019
@mih mih closed this in #3402 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant