New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF: lgr - use .setLevel() instead of .level = #3935
Conversation
Apparently .level is not even a property and I guess starting from 3.7 treatment has changed, or broke. May be smth like (scheduled for 3.9 with backport requests for 3.8) python/cpython#16325 was intended to fix it, I did not investigate deep enough -- just fixed the issue we started to experience (Closes datalad#3545)
Running a test that I know was problematic earlier, I can confirm that this quiets it. Thanks. |
FWIW my opinion is that the extra PR is unnecessary. A local merge and push is fine unless that merge is particularly involved (and even in those cases, I think pushing to a scratch branch to make sure the tests passes is usually sufficient). |
Ack |
FTR: bug is interesting in that it manifested itself only after 2nd use of swallow_logs |
Weird. I remember that when I looked into it a bit when reporting, I couldn't figure out why the issue didn't seem to affect some tests. That probably explains it. |
Codecov Report
@@ Coverage Diff @@
## 0.11.x #3935 +/- ##
==========================================
+ Coverage 81.14% 89.91% +8.77%
==========================================
Files 256 253 -3
Lines 34050 34045 -5
==========================================
+ Hits 27629 30611 +2982
+ Misses 6421 3434 -2987
Continue to review full report at Codecov.
|
Before and after. Much better. Thanks @yarikoptic. |
coolio, pushed master with 0.11.x (just this PR) merged |
Apparently .level is not even a property and I guess starting from
3.7 treatment has changed, or broke. May be smth like (scheduled for 3.9
with backport requests for 3.8) python/cpython#16325
was intended to fix it, I did not investigate deep enough -- just fixed
the issue we started to experience (Closes #3545)
After merged into 0.11.x, will send PR against master