Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected install/clone behavior (relpath misinterpretation) #3958

Closed
mih opened this issue Dec 21, 2019 · 1 comment · Fixed by #3966
Closed

Unexpected install/clone behavior (relpath misinterpretation) #3958

mih opened this issue Dec 21, 2019 · 1 comment · Fixed by #3966
Labels
fix-implemented severity-normal

Comments

@mih
Copy link
Member

@mih mih commented Dec 21, 2019

I ran

In [1]: import datalad.api as dl                                                             
In [7]: dl.install('~/forrest/collection/phase2', 'dest2')                                   
[INFO   ] Cloning dest2 into '/tmp/~/forrest/collection/phase2' 
Out[7]: <Dataset path=/tmp/~/forrest/collection/phase2>

I my case both locations have a dataset, so I expected failure and was surprised by the success. It is mistaking the ~ path for a relative path specification. clone has the same issue.

@mih mih added the severity-normal label Dec 21, 2019
@mih mih changed the title Unexpected install/clone behavior Unexpected install/clone behavior (relpath misinterpretation) Dec 21, 2019
@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Dec 21, 2019

I guess we need expanduser() on each path

mih added a commit to mih/datalad that referenced this issue Dec 27, 2019
@mih mih mentioned this issue Dec 27, 2019
18 tasks
@mih mih added the fix-implemented label Jan 1, 2020
@mih mih closed this as completed in #3966 Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-implemented severity-normal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants