Skip to content

Support ConfigManager.set(where='override') #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mih opened this issue Dec 28, 2019 · 0 comments · Fixed by #3978
Closed

Support ConfigManager.set(where='override') #3970

mih opened this issue Dec 28, 2019 · 0 comments · Fixed by #3978
Labels
fix-implemented A fix is available, but has not been merged or released, yet. UX user experience

Comments

@mih
Copy link
Member

mih commented Dec 28, 2019

Otherwise users need to know that this dance is needed to have any affect on a running instance:

(Pdb) cfg.overrides['datalad.log.level']= 'debug'
(Pdb) cfg.overrides
{'datalad.log.level': 'debug'}
(Pdb) cfg.get('datalad.log.level')
(Pdb) cfg.overrides
{'datalad.log.level': 'debug'}
(Pdb) cfg.reload()
(Pdb) cfg.get('datalad.log.level')
'100'
@mih mih added the UX user experience label Dec 28, 2019
mih added a commit to mih/datalad that referenced this issue Jan 2, 2020
@mih
NF: ConfigManager.???(where='override')
5e02890 
This brings the same (and actually more) configuration override
flexibility to the Python API that the cmdline API offers via
`datalad -c key=val`.

This feature is a necessity for being able to rely on one-off
configuration (changes) to alter command behavior, whenever
a dedicated command option is not absolutely needed or shall be
avoided.

A dedicated test for overrides is also included.

Fixes dataladgh-3970
@mih mih mentioned this issue Jan 2, 2020
Merged
@mih mih added the fix-implemented A fix is available, but has not been merged or released, yet. label Jan 2, 2020
@mih mih closed this as completed in #3978 Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix-implemented A fix is available, but has not been merged or released, yet. UX user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NF: ConfigManager.???(where='override') mih/datalad
1 participant
@mih