Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone.py:_get_installation_path_from_url() broken on Windows #3971

Closed
mih opened this issue Dec 28, 2019 · 0 comments
Closed

clone.py:_get_installation_path_from_url() broken on Windows #3971

mih opened this issue Dec 28, 2019 · 0 comments
Assignees
Labels
fix-implemented platform-windows
Projects

Comments

@mih
Copy link
Member

@mih mih commented Dec 28, 2019

On Debian:

In [2]: _get_installationpath_from_url('/bin/mf/this')                                          
Out[2]: 'this'

On Windows:

(Pdb) print(source)
C:\Users\mih\AppData\Local\Temp\datalad_temp_testrepo_31j9ihq6
(Pdb) _get_installationpath_from_url(source)
'C:\\Users\\mih\\AppData\\Local\\Temp\\datalad_temp_testrepo_31j9ihq6'

which leads to all kinds of follow-up errors, because a clone into the source location is attempted.

@mih mih added the platform-windows label Dec 28, 2019
@mih mih mentioned this issue Dec 28, 2019
18 tasks
@mih mih self-assigned this Dec 29, 2019
mih added a commit to mih/datalad that referenced this issue Dec 29, 2019
_get_installationpath_from_url() cannot handle Windows paths
@mih mih added the fix-implemented label Dec 29, 2019
@mih mih added this to Major issues in Windows Jan 1, 2020
@mih mih moved this from Major issues to Done in Windows Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-implemented platform-windows
Projects
No open projects
Windows
  
Done
Development

No branches or pull requests

1 participant