Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of shlex.split() likely causing issues on Windows #4049

Closed
mih opened this issue Jan 19, 2020 · 0 comments · Fixed by #4053
Closed

Use of shlex.split() likely causing issues on Windows #4049

mih opened this issue Jan 19, 2020 · 0 comments · Fixed by #4053
Labels
fix-implemented A fix is available, but has not been merged or released, yet. platform-windows Issue concerned with Windows severity-important major effect on the usability of a package, without rendering it completely unusable to everyone
Projects

Comments

@mih
Copy link
Member

mih commented Jan 19, 2020

Used in

  • run_procedure()
  • Runner.run()
  • AddArchiveContent
  • AnnexRepo._annex_custom_command()
  • AnnexRepo.copy_to()
  • GitRepo._git_custom_command()
  • sshrun()
  • test_cmd.py

Solution candidate:
https://stackoverflow.com/questions/33560364/python-windows-parsing-command-lines-with-shlex/35900070#35900070

However, each use of split() should be investigated, because splitting for the purpose of Popen is unnecessary and would be immediately undone by it.

@mih mih added platform-windows Issue concerned with Windows severity-important major effect on the usability of a package, without rendering it completely unusable to everyone labels Jan 19, 2020
mih added a commit to mih/datalad that referenced this issue Jan 20, 2020
shlex.split() is kept for any non-Windows platform, as custom
implementation for Windows was added. All use of shlex.split()
was replaced by the new helper.

Fixes dataladgh-4049
@mih mih added the fix-implemented A fix is available, but has not been merged or released, yet. label Jan 20, 2020
mih added a commit to mih/datalad that referenced this issue Jan 20, 2020
shlex.split() is kept for any non-Windows platform, as custom
implementation for Windows was added. All use of shlex.split()
was replaced by the new helper.

Fixes dataladgh-4049
@mih mih closed this as completed in #4053 Jan 20, 2020
@mih mih added this to Done in Windows Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-implemented A fix is available, but has not been merged or released, yet. platform-windows Issue concerned with Windows severity-important major effect on the usability of a package, without rendering it completely unusable to everyone
Projects
No open projects
Windows
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant