-
Notifications
You must be signed in to change notification settings - Fork 124
Use of shlex.split() likely causing issues on Windows #4049
Copy link
Copy link
Closed
Labels
fix-implementedA fix is available, but has not been merged or released, yet.A fix is available, but has not been merged or released, yet.platform-windowsIssue concerned with WindowsIssue concerned with Windowsseverity-importantmajor effect on the usability of a package, without rendering it completely unusable to everyonemajor effect on the usability of a package, without rendering it completely unusable to everyone
Metadata
Metadata
Assignees
Labels
fix-implementedA fix is available, but has not been merged or released, yet.A fix is available, but has not been merged or released, yet.platform-windowsIssue concerned with WindowsIssue concerned with Windowsseverity-importantmajor effect on the usability of a package, without rendering it completely unusable to everyonemajor effect on the usability of a package, without rendering it completely unusable to everyone
Used in
run_procedure()Runner.run()AddArchiveContentAnnexRepo._annex_custom_command()AnnexRepo.copy_to()GitRepo._git_custom_command()sshrun()test_cmd.pySolution candidate:
https://stackoverflow.com/questions/33560364/python-windows-parsing-command-lines-with-shlex/35900070#35900070
However, each use of split() should be investigated, because splitting for the purpose of
Popenis unnecessary and would be immediately undone by it.