ENH: Move git-annex-ria-remote to datalad core as git-annex-ora-remote (2nd attempt) #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove entirely when not necessary. If necessary 'ria' refers to the concept of a store, whether the datasets are addressable by their dataset ID. A further renaming will happen as part of dataladgh-4164, where 'ria-remote' (the special remote implementation) is replaced by 'ora-remote'. Together, this changes disambiguate the term 'ria'. This change also removes TODOs from the documentation.
This is (almost) a plain copy from original repository at github.com/datalad/git-annex-ria-remote.
We currently can't properly deal with file-scheme URIs for windows paths. Tests and url config for special remote need to change anyway, may be it's actually doable then.
actually implemented for get over SSH only ATM
The stored URL of the special remote in the git-annex branch might be invalid on another system. If autoenable fails on clone, it could now read the UUID of the special remote, that was supposed to be enabled, fallback to the clone-URL and try again to enable it.
Don't store the URL, that was passed to initremote in git-annex:remote.log, but the rewritten URL. Otherwise it would be invalid on another system, that lacks the replacement config (url.<base>.insteadOf)
We easily exceed Travis time limit otherwise.
Use @turtle to mark a test as too slow to run on Travis.
This test takes just too long for Travis.
…name Which is happening: datalad#4259
Instead of just crashing.
in AnnexRepo.localsync()
5 tasks
The behavior of printf is more predictable across systems.
Codecov Report
@@ Coverage Diff @@
## master #4260 +/- ##
==========================================
- Coverage 89.43% 88.70% -0.73%
==========================================
Files 275 282 +7
Lines 36182 36887 +705
==========================================
+ Hits 32358 32721 +363
- Misses 3824 4166 +342
Continue to review full report at Codecov.
|
|
OK, I will merge this now. I realize that this is a bit forced, but having this hanging in a PR complicates related efforts substantially. The code should be organized in a way that its impact on existing functionality should be minimal. You can rightfully blame any fallout on me, and I promise to take care of it. |
This was referenced Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #4258, and incorporates and replaces #4164.
Major changes in addition to those two base PRs are:
ria_export_archive()work on crippled FS