Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone fails to annex-init due to discovery of "chained" origins #4367

Closed
bpoldrack opened this issue Apr 1, 2020 · 0 comments
Closed

clone fails to annex-init due to discovery of "chained" origins #4367

bpoldrack opened this issue Apr 1, 2020 · 0 comments
Assignees
Labels
severity-normal

Comments

@bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Apr 1, 2020

I have repo with autoenabled special remote and clone it. Gets enabled, I can obtain data - all good. Now I clone it from that clone to a third location. Special remote isn't autoenabled, while git annex init will do it. Nevertheless I have a git-annex branch and a filled .git/annex before that annex-init call.

What's happening is, that we discover from within clone, that there is that original origin which we add to the clone of the clone as well as origin-2 and try to enable it to figure its UUID. This git-annex enableremote call is done right before we check whether we need to git-annex-init the fresh clone and now it looks already initialized to us, since we find a local git-annex branch and everything. Therefore we don't call git-annex-init.

Trying to fix this by simply change the order of things. A possible need for annex-init should be considered before anything else, I think.

@bpoldrack bpoldrack self-assigned this Apr 1, 2020
@bpoldrack bpoldrack added the severity-normal label Apr 1, 2020
bpoldrack added a commit to bpoldrack/datalad that referenced this issue Apr 1, 2020
instead of potentially calling git-annex-enableremote
with a discovered 2nd-level origin. The latter
messes with our detection whether a repo is initialized.

TODO: This is to be ammended with a test. Just pushing
to see whether the fix breaks anything

(Closes datalad#4367)
bpoldrack added a commit to bpoldrack/datalad that referenced this issue Apr 1, 2020
instead of potentially calling git-annex-enableremote
with a discovered 2nd-level origin. The latter
messes with our detection whether a repo is initialized.

(Closes datalad#4367)
bpoldrack added a commit to bpoldrack/datalad that referenced this issue Apr 1, 2020
instead of potentially calling git-annex-enableremote
with a discovered 2nd-level origin. The latter
messes with our detection whether a repo is initialized.

(Closes datalad#4367)
@kyleam kyleam closed this as completed in 2bf2784 Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity-normal
Projects
None yet
Development

No branches or pull requests

1 participant