BF: version test in RIA stores #5607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a problem with the version check for a newly created dataset, which would perform a local test, even if the sibling is on an SSH host.
mih
changed the title
bpoldrack
approved these changes
Apr 28, 2021
Codecov Report
@@ Coverage Diff @@
## maint #5607 +/- ##
==========================================
- Coverage 90.22% 90.22% -0.01%
==========================================
Files 299 299
Lines 42232 42230 -2
==========================================
- Hits 38102 38100 -2
Misses 4130 4130
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with the version check for a newly created dataset, which would perform a local test, even if the sibling is on an SSH host.
I will propose a PR against the mainline too.