Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move interface.utils.eval_results to interface(.base) #6694

Closed
mih opened this issue May 18, 2022 · 2 comments · Fixed by #7170
Closed

Move interface.utils.eval_results to interface(.base) #6694

mih opened this issue May 18, 2022 · 2 comments · Fixed by #7170
Labels
DX developer experience

Comments

@mih
Copy link
Member

mih commented May 18, 2022

There is pretty much no Interface implementation without it, just like with build_doc. IMHO both pieces should live in the same place.

This would make the common

from datalad.interface.base import (
    Interface,
    build_doc,
)
from datalad.interface.utils import (
    eval_results,
)

just be

from datalad.interface.base import (
    Interface,
    build_doc,
    eval_results,
)

an argument could be made to consolidate all (more or less strictly) required pieces in datalad.interface. Looking like this:

from datalad.interface.base import (
    Interface,
    Parameter,
    build_doc,
    datasetmethod,
    eval_results,
)
@mih mih added the DX developer experience label May 18, 2022
adswa added a commit to adswa/datalad that referenced this issue Nov 11, 2022
@adswa adswa linked a pull request Nov 11, 2022 that will close this issue
@adswa
Copy link
Member

adswa commented Nov 17, 2022

done in #7170

@adswa adswa closed this as completed Nov 17, 2022
@yarikoptic-gitmate
Copy link
Collaborator

Issue fixed in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX developer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants