Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move with_testrepos to deprecated? #6752

Closed
mih opened this issue Jun 8, 2022 · 1 comment
Closed

Move with_testrepos to deprecated? #6752

mih opened this issue Jun 8, 2022 · 1 comment

Comments

@mih
Copy link
Member

mih commented Jun 8, 2022

#6690 removes the last traces of its usage from the core package.

From my POV there are only few points of usage left across all extensions, and all in deprecated

./deprecated/datalad_deprecated/tests/test_auto.py:@with_testrepos('basic_annex', flavors=['clone'])
./deprecated/datalad_deprecated/tests/test_publish.py:@with_testrepos('submodule_annex', flavors=['local'])
./deprecated/datalad_deprecated/tests/test_publish.py:@with_testrepos('submodule_annex', flavors=['local'])  #TODO: Use all repos after fixing them
./deprecated/datalad_deprecated/tests/test_publish.py:@with_testrepos('basic_git', flavors=['local'])
./deprecated/datalad_deprecated/tests/test_publish.py:@with_testrepos('submodule_annex', flavors=['local'])
./deprecated/datalad_deprecated/tests/test_publish.py:@with_testrepos('submodule_annex', flavors=['local'])  #TODO: Use all repos after fixing them
./deprecated/datalad_deprecated/tests/test_publish.py:@with_testrepos('submodule_annex', flavors=['local'])
./deprecated/datalad_deprecated/tests/test_publish.py:@with_testrepos('submodule_annex', flavors=['local'])  #TODO: Use all repos after fixing them
./deprecated/build/lib/datalad_deprecated/tests/test_auto.py:@with_testrepos('basic_annex', flavors=['clone'])

We can either move with_testrepos into this extension and adjust the imports, or change those tests. In either case with_testrepos can be removed from the core package.

adswa added a commit to datalad/datalad-deprecated that referenced this issue Nov 15, 2022
They are unused in core, and mostly relevant for tests in
this module. See datalad/datalad#6752
adswa added a commit to adswa/datalad that referenced this issue Nov 15, 2022
Following the proposal in datalad#6752
@adswa
Copy link
Member

adswa commented Nov 25, 2022

Fixed with #7176

@adswa adswa closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants