Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error result generation crashes with --existing=error (default) #6950

Closed
mih opened this issue Aug 17, 2022 · 1 comment · Fixed by #6952
Closed

Error result generation crashes with --existing=error (default) #6950

mih opened this issue Aug 17, 2022 · 1 comment · Fixed by #6952
Labels
cmd-create-sibling-ria

Comments

@mih
Copy link
Member

mih commented Aug 17, 2022

Running a create-sibling-ria call twice makes it crash:

% datalad -C dist/packages/demo create-sibling-ria -s internal --shared group --group floppy --alias pkg-demo ria+file:///tmp/wt/internal                                                
[ERROR  ] datalad.interface.results.get_status_dict() got multiple values for keyword argument 'ds' (TypeError)

Offending code in datalad/distributed/create_sibling_ria.py

352  ->                 res = get_status_dict(
353                         status='error',
354                         message=(
355                             "a sibling %r is already configured in dataset %r",
356                             sname, dpath),
357                         type='sibling',
358                         name=sname,
359                         ds=ds,
360                         **res_kwargs,
361                     )

with

296             res_kwargs = dict(
297                 ds=ds,
298                 action="create-sibling-ria",
299                 logger=lgr,
300             )
adswa added a commit to adswa/datalad that referenced this issue Aug 17, 2022
@adswa
BF: Remove duplicate ds key from result record
6393b96 
fixes datalad#6950
adswa added a commit to adswa/datalad that referenced this issue Aug 17, 2022
@adswa
TST: Add a testcase for datalad#6950
07c596f
@adswa adswa mentioned this issue Aug 17, 2022
Merged
@adswa adswa linked a pull request Aug 17, 2022 that will close this issue
BF: Remove duplicate key in result record #6952
Merged
yarikoptic pushed a commit that referenced this issue Aug 17, 2022
@adswa @yarikoptic
BF: Remove duplicate ds key from result record
a437ec1 
fixes #6950
yarikoptic pushed a commit that referenced this issue Aug 17, 2022
@adswa @yarikoptic
TST: Add a testcase for #6950
5f0b28d
yarikoptic added a commit that referenced this issue Aug 20, 2022
@yarikoptic
Merge remote-tracking branch 'origin/maint'
80aa7b5 
* origin/maint: (24 commits)
  BF(TEMP): use git-annex from neurodebian -devel to gain fix for bug detected with datalad-crawler
  BF(TST): use introduced _p instead of _path_ an denable test_path_prefix testing on windows
  BF: f-prefix the f-string
  BF: use .as_posix to convert to posix, name posix_paths for clarity
  BF+RF(TST): mark path_prefix back to skip, use custom _p helper for paths
  BF(TST): apparently description is getting set to target_url
  BF: convert submodule relative path to PurePosixPath before giving to get_parent_paths
  ENH+BF: get_parent_paths - make / into sep option and consistently use / as path separator
  Safety-net to prevent data-loss by drop from symlink'ed annex
  BF(TST): prevent auto-upgrade of "remote" test sibling, do not use local path for URL
  [DATALAD RUNCMD] DOC: allow codespell to fix all typos it finds
  RF: replace 2 letter abbrevs with some meaningful words
  Remove no longer needed import
  BF(TST): make tests use _path_ helper for Windows "friendliness" of the tests
  Avoid unicode in test that does not strictly require this complication
  TST: Add a testcase for #6950
  BF: Remove duplicate ds key from result record
  NF: tools/eval_under_nfs to help running tests under NFS partition
  Acknowledge git-config comment chars
  DOC: Datalad -> DataLad
  ...
@yarikoptic-gitmate
Copy link
Collaborator

Issue fixed in 0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd-create-sibling-ria
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BF: Remove duplicate key in result record adswa/datalad
2 participants
@mih @yarikoptic-gitmate