Move old-style metadata facilities to deprecated
#7012
Assignees
Comments
mih
added a commit
to mih/datalad
that referenced
this issue
Sep 7, 2022
This changeset is part of the transition from the 2nd-gen metadata
implementation to then gen3 code provided by the -metalad extension.
This removal has side-effect on other code, not directly related
to metadata. This following list can be considered a TODO for further
maintenance work:
Now unused code:
- `datalad/support/json_py.py:load_xzstream()`
- `datalad/interface/common_opts.py:reporton_opt`
- `datalad/utils.py:all_same()`
- `datalad/utils.py:as_unicode()`
- `datalad/utils.py:unicode_srctypes` made obsolete by removal of `as_unicode()`
Now barely used (technical debt?):
- `nosave_opt`: Residual use in `addurls()` and `download_url()`
- `datalad/support/path.py:split_ext()`: Residual use in a single spot in `addurls()`
- `datalad/utils.py:path_startswith()`: 2 pieces of code still use this outside the tests
- `datalad/utils.py:get_suggestions_msg()`: CLI parser and `addurls()` make the total of 2 calls made to this helper
- `datalad/utils.py:shortened_repr()`: one call in `get()` and one in `foreach_dataset()`
Issues to file:
- [ ] Investigate whether the dependency on `simplejson` is still needed.
- [ ] `datalad/interface/utils.py:discover_dataset_trace_to_targets()`
is now an internal helper of `save()`
Closes datalad#7012
7 tasks
|
I will take this one. Plan:
|
christian-monch
pushed a commit
to mih/datalad
that referenced
this issue
Oct 20, 2022
This changeset is part of the transition from the 2nd-gen metadata
implementation to then gen3 code provided by the -metalad extension.
This removal has side-effect on other code, not directly related
to metadata. This following list can be considered a TODO for further
maintenance work:
Now unused code:
- `datalad/support/json_py.py:load_xzstream()`
- `datalad/interface/common_opts.py:reporton_opt`
- `datalad/utils.py:all_same()`
- `datalad/utils.py:as_unicode()`
- `datalad/utils.py:unicode_srctypes` made obsolete by removal of `as_unicode()`
Now barely used (technical debt?):
- `nosave_opt`: Residual use in `addurls()` and `download_url()`
- `datalad/support/path.py:split_ext()`: Residual use in a single spot in `addurls()`
- `datalad/utils.py:path_startswith()`: 2 pieces of code still use this outside the tests
- `datalad/utils.py:get_suggestions_msg()`: CLI parser and `addurls()` make the total of 2 calls made to this helper
- `datalad/utils.py:shortened_repr()`: one call in `get()` and one in `foreach_dataset()`
Issues to file:
- [ ] Investigate whether the dependency on `simplejson` is still needed.
- [ ] `datalad/interface/utils.py:discover_dataset_trace_to_targets()`
is now an internal helper of `save()`
Closes datalad#7012
|
Issue fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Protocol of plan made in devcall:
Move remaining metadata commands to
-deprecatedmetadataaggregate:-metadatasearchAnnounce this plan now (informally), and release the move with the next major release.
With that announcement, we announce that
metaladprovides the next generation metadata handling for datalad.There is no requirement for
metaladto provide an API-compatible replacement for these commands. Rather, it is appreciated for them to stay intact and usable in parallel with-deprecatedinstalled.The text was updated successfully, but these errors were encountered: