Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner cannot handle run(cwd=Path) #7040

Closed
mih opened this issue Sep 15, 2022 · 2 comments · Fixed by #7107
Closed

Runner cannot handle run(cwd=Path) #7040

mih opened this issue Sep 15, 2022 · 2 comments · Fixed by #7107
Labels
DX developer experience team-runner sub-process execution and IO (https://github.com/datalad/datalad/issues/6365)

Comments

@mih
Copy link
Member

mih commented Sep 15, 2022

Docs say: cwd : path-like, optional

Made me assume that a Path instance would work, but it does not. At least not when passed to run(). It does work, when passed to the constructor (same docs of the argument there).

On Windows, such a path obj ends up in the environment, leading to unexpected results.

@mih mih added DX developer experience team-runner sub-process execution and IO (https://github.com/datalad/datalad/issues/6365) labels Sep 15, 2022
@christian-monch
Copy link
Contributor

There is old code in the runner that puts a modified path into the alternative environment if an alternative environment is provided. This code did not account for the possibility of Path-objects in cwd. This should be fixed by #7107

@yarikoptic-gitmate
Copy link
Collaborator

Issue fixed in 0.17.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX developer experience team-runner sub-process execution and IO (https://github.com/datalad/datalad/issues/6365)
Projects
None yet
4 participants