Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_procedure() unconditionally renders subdataset() output #7091

Closed
mih opened this issue Oct 15, 2022 · 2 comments · Fixed by #7094
Closed

run_procedure() unconditionally renders subdataset() output #7091

mih opened this issue Oct 15, 2022 · 2 comments · Fixed by #7094
Assignees
Labels
cmd-run-procedure severity-normal standard severity UX user experience

Comments

@mih
Copy link
Member

mih commented Oct 15, 2022

Discovered in datalad/datalad-gooey#373

Fix

diff --git a/datalad/local/run_procedure.py b/datalad/local/run_procedure.py
index 4d195b1de..72e7ee0ae 100644
--- a/datalad/local/run_procedure.py
+++ b/datalad/local/run_procedure.py
@@ -141,7 +141,8 @@ def _get_procedure_implementation(name='*', ds=None):
                 yield (m, n,) + _get_proc_config(n, ds=ds)
         # 2.1. check subdatasets recursively
         for subds in ds.subdatasets(return_type='generator',
-                                    result_xfm='datasets'):
+                                    result_xfm='datasets',
+                                    result_renderer='disabled'):
             for m, n, f, h in _get_procedure_implementation(name=name, ds=subds):
                 yield m, n, f, h
 
@mih mih added severity-normal standard severity UX user experience cmd-run-procedure labels Oct 15, 2022
mslw added a commit to mslw/datalad that referenced this issue Oct 17, 2022
Disables subdataset result renderer inside run_procedure. This is an
internal call, so results are not needed. Fixes datalad#7091.

Co-authored-by: Michael Hanke <michael.hanke@gmail.com>
@mslw mslw self-assigned this Oct 17, 2022
@adswa adswa linked a pull request Oct 19, 2022 that will close this issue
@yarikoptic-gitmate
Copy link
Collaborator

Issue fixed in 0.17.8

@christian-monch
Copy link
Contributor

Fixed by PR #7094

adswa pushed a commit to adswa/datalad that referenced this issue Oct 26, 2022
Disables subdataset result renderer inside run_procedure. This is an
internal call, so results are not needed. Fixes datalad#7091.

Co-authored-by: Michael Hanke <michael.hanke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd-run-procedure severity-normal standard severity UX user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants