Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Butchered datalad_urls on Windows when cloning subdatasets from local paths #7182

Closed
adswa opened this issue Nov 16, 2022 · 1 comment · Fixed by #7183
Closed

Butchered datalad_urls on Windows when cloning subdatasets from local paths #7182

adswa opened this issue Nov 16, 2022 · 1 comment · Fixed by #7183
Labels
platform-windows Issue concerned with Windows

Comments

@adswa
Copy link
Member

adswa commented Nov 16, 2022

On Windows, the source of a clone call is passed as is into the .gitmodules file of the superdataset as the value for datalad_url. If this source is a local path, the resulting value can be something like

datalad_url = ..\\origin

(which makes sense on no platform at all). It should rather be a posix like URL, as any URL in Git's configuration files is.
adswa added a commit to adswa/datalad that referenced this issue Nov 16, 2022
@adswa
BF: Ensure that datalad urls are posix
dcf1cb8 
Fixes datalad#7182
adswa added a commit to adswa/datalad that referenced this issue Nov 16, 2022
@adswa
BF: Ensure that datalad urls are posix
c80455f 
Fixes datalad#7182
@adswa adswa mentioned this issue Nov 16, 2022
Merged
@adswa adswa added the platform-windows Issue concerned with Windows label Nov 28, 2022
bpoldrack pushed a commit to adswa/datalad that referenced this issue Nov 30, 2022
@adswa @bpoldrack
Ensure that datalad-url uses posix paths
a45453a 
Fixes datalad#7182
@yarikoptic-gitmate
Copy link
Collaborator

Issue fixed in 0.17.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform-windows Issue concerned with Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BF: Ensure that datalad urls are posix adswa/datalad
2 participants
@adswa @yarikoptic-gitmate