TEMP: #1451
Closed
TEMP: #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption when asked to commit files unknown to git (Closes datalad#1291)
…e when used with explicit paths to commit
ENH: provide 'files' parameter for commit ENH: Don't log git commit call failures at ERROR level
ENH: enable ok_clean_git's untracked_files feature for any AnnexRepo
…rectory - just as 'git status' does
BF: AnnexRepo.untracked_files does what is availabe, if annex-status-bug is preventing regular call BF: Workaround for AnnexRepo.add(git=True) in v6. Ugly but enables us to see behind test failures, caused by this one. TST: Several v6 fixes in test_annexrepo.py Additional notes and minor changes
…loses datalad#1319) (cherry picked from commit 1df1f13)
…s' own recursive inspection of submodules
…cursion in AnnexRepo.status()
BF: Again, don't use annex-proxy for committing in direct mode, since it fails, when a passed path is a submodule (in direct mode) Additional notes and minor corrections
Disabling the lazy loading of Dataset.repo, since it conflicts with flyweight implementation. Both needs further discussion. See issue datalad#1345
- lock - unlock - adjust - unannex
- added several TODOs - identified more bugs (annex sync, committing of direct mode submodules, ...)
for workaround 'datalad unlock' just failed in direct mode and refactored to move the special treatment into AnnexRepo.unlock()
…tatus fails in a submodule without a working tree
…mmands in direct mode by default RF/BF: remove several usages of annex-proxy, since this leads to the need to also commit via annex-proxy. Therefore we would have to constantly decide how exactly to commit in direct mode. This involves: - git-add - git-rm RF: don't use gitpython's builtin git-rm implementation, since we can't make it use all options we need. TST: Remove explicit direct mode test from test_annex_remove; we have a dedicated build for that purpose TST: Adapt test_AnnexRepo_status
…against-returnvalues
1. to be inline with other methods which are other imperative or a property 2. to make more sense/correspondence with reality (takes a single submodule)
1. to stay consistent with other methods in the *Repo API. Imperative names for methods and nouns for properties. is_ is a common prefix for such methods with only few exceptions which we might like to address 2. to minimize the diff (make it easier to review) for the PR#1450
yarikoptic
force-pushed
the
bf-direct-against-returnvalues
branch
from
483222d
to
8b055fd
Compare
|
closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to see the effect of perspective bpoldrack#35
and to make review of #1450 more adequate to the functionality changes not API breakage