Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ENH progressbars for addurl #2738
This pull request fixes datalad/datalad-container#49
I guess would require manual testdriving since it is UI which we might not test very thoroughly automatically. But on my attempts seems to be quite kosher.
@@ Coverage Diff @@ ## master #2738 +/- ## ========================================== + Coverage 90.42% 90.48% +0.05% ========================================== Files 245 245 Lines 31210 31467 +257 ========================================== + Hits 28223 28472 +249 - Misses 2987 2995 +8
I tried this out on a few
containers-add calls. Looks nice! I've left a few minor comments.
I've restarted a travis build (hopefully uploaded fresh git-annex resolves the issue) since failure looked unrelated. I am afraid I did break something with this PR since my checks I had to add hint that something is behaving differently now. But I am afraid that due to this "interactive" nature of the element here, we would only discover by trying it out.