Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ENH(UI): interface our progress bars into GitPython for clone/push/pull #2876
This pull request fixes #1564
This pull request proposes to provide GitPython with our progress reporting for clone/push/pull. May be there is other command where it could be provided - didn't find with
Hmm, I tried
@@ Coverage Diff @@ ## master #2876 +/- ## ========================================== - Coverage 90.3% 90.29% -0.01% ========================================== Files 246 246 Lines 31872 31929 +57 ========================================== + Hits 28782 28831 +49 - Misses 3090 3098 +8
ok -- the reason for a test failure all around is our good old reliance on parsing stderr from
This was referenced
Sep 27, 2018
referenced this pull request
Sep 28, 2018
The progress reporting looks nice on my end (py3). I looked over the code and don't have any major comments.
I'm still confused about the py2 issues. It's not clear to me based on your comments whether you figured out what the issue is. I'm guessing you haven't because, based on quick testing under python 2, things still look off to me. In that case, it would have been nice to see some mention/discussion of this in the commit messages or code comments so that it's clear that it is a known issue to someone investigating it later.
Oct 2, 2018
8 of 10 checks passed
The main point of my review was: "it would have been nice to see some mention/discussion of this in the commit messages or code comments so that it's clear that it is a known issue to someone investigating it later."