Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(TST): realpath path before figuring out which repo it belongs to #2972

Merged
merged 2 commits into from Nov 8, 2018

Conversation

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Nov 2, 2018

Surprisingly, I ran into it only within #2898
despite all our testing with symlinked TMPDIRs on travis. This time I have added
a dedicated unittest to trigger that failure.

The rationale for using realpath there is because GitRepo already realpath"ing
the path to be able to return the singleton Repo for the same path

This pull request fixes #2961

Surprisingly ran into it only within datalad#2898
despite all our testing with symlinked TMPDIRs on travis.  This time I have added
a dedicated unittest to trigger that failure.

The rationale for using realpath there is because GitRepo already realpath"ing
the path to be able to return the singleton Repo for the same path
@yarikoptic yarikoptic added this to the Release 0.11.1 milestone Nov 5, 2018
@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented Nov 6, 2018

@datalad/developers please review or I would merge as is within a day or so

datalad/tests/utils.py Outdated Show resolved Hide resolved
@bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Nov 8, 2018

Apart from the typo - LGTM

Co-Authored-By: yarikoptic <debian@onerussian.com>
@codecov
Copy link

@codecov codecov bot commented Nov 8, 2018

Codecov Report

Merging #2972 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2972      +/-   ##
==========================================
+ Coverage   90.35%   90.36%   +<.01%     
==========================================
  Files         246      246              
  Lines       32136    32156      +20     
==========================================
+ Hits        29038    29058      +20     
  Misses       3098     3098
Impacted Files Coverage Δ
datalad/tests/utils.py 89.37% <100%> (+0.01%) ⬆️
datalad/tests/test_tests_utils.py 98.63% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b6e48...78af762. Read the comment docs.

@yarikoptic yarikoptic merged commit 8f8efdd into datalad:master Nov 8, 2018
1 of 3 checks passed
@yarikoptic yarikoptic deleted the bf-ok_file_under_git branch Nov 21, 2018
yarikoptic added a commit that referenced this issue Nov 27, 2018
	## 0.11.1 (Nov 25, 2018) -- v7-better-than-v6

	Rushed out bugfix release to stay fully compatible with recent
	[git-annex] which introduced v7 to replace v6.

	### Fixes

	- [install]: be able to install recursively into a dataset ([#2982])
	- [save]: be able to commit/save changes whenever files potentially
	  could have swapped their storage between git and annex
	  ([#1651]) ([#2752]) ([#3009])
	- [aggregate-metadata]:
	  - dataset's itself is now not "aggregated" if specific paths are
		provided for aggregation ([#3002]). That resolves the issue of
		`-r` invocation aggregating all subdatasets of the specified dataset
		as well
	  - also compare/verify the actual content checksum of aggregated metadata
		while considering subdataset metadata for re-aggregation ([#3007])
	- `annex` commands are now chunked assuming 50% "safety margin" on the
	  maximal command line length. Should resolve crashes while operating
	  ot too many files at ones ([#3001])
	- `run` sidecar config processing ([#2991])
	- no double trailing period in docs ([#2984])
	- correct identification of the repository with symlinks in the paths
	  in the tests ([#2972])
	- re-evaluation of dataset properties in case of dataset changes ([#2946])
	- [text2git] procedure to use `ds.repo.set_gitattributes`
	  ([#2974]) ([#2954])
	- Switch to use plain `os.getcwd()` if inconsistency with env var
	  `$PWD` is detected ([#2914])
	- Make sure that credential defined in env var takes precedence
	  ([#2960]) ([#2950])

	### Enhancements and new features

	- [shub://datalad/datalad:git-annex-dev](https://singularity-hub.org/containers/5663/view)
	  provides a Debian buster Singularity image with build environment for
	  [git-annex]. [tools/bisect-git-annex]() provides a helper for running
	  `git bisect` on git-annex using that Singularity container ([#2995])
	- Added [.zenodo.json]() for better integration with Zenodo for citation
	- [run-procedure] now provides names and help messages with a custom
	  renderer for ([#2993])
	- Documentation: point to [datalad-revolution] extension (prototype of
	  the greater DataLad future)
	- [run]
	  - support injecting of a detached command ([#2937])
	- `annex` metadata extractor now extracts `annex.key` metadata record.
	  Should allow now to identify uses of specific files etc ([#2952])
	- Test that we can install from http://datasets.datalad.org
	- Proper rendering of `CommandError` (e.g. in case of "out of space"
	  error) ([#2958])

* tag '0.11.1':
  Adjust the date -- 25th fell through due to __version__ fiasco
  BF+ENH(TST): boost hardcoded version + provide a test to guarantee consistency in the future
  This (expensive) approach is not needed in v6+
  small tuneup to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants