Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Work around some worktree-related failures #3129

Merged
merged 2 commits into from Jan 28, 2019

Conversation

@kyleam
Copy link
Contributor

@kyleam kyleam commented Jan 28, 2019

Based on local testing, three tests fail with an
InvalidGitRepositoryError when executed from within a git worktree of
the codebase: test_create_sibling.test_invalid_call,
test_run_procedure.test_invalid_call (gh-3052), and
test_run_procedure.test_procedure_discovery.

Avoid these errors by switching to a temporary, non-repo directory
before running the tests.

Re: #3029
Fixes #3052.


The last commit adjusts Travis so that the tests are executed from a worktree. This is intended as a temporary check for additional failures because I don't think it's worth adding another dedicated Travis run to check for worktree testing issues.

Based on local testing, three tests fail with an
InvalidGitRepositoryError when executed from within a git worktree of
the codebase: test_create_sibling.test_invalid_call,
test_run_procedure.test_invalid_call (dataladgh-3052), and
test_run_procedure.test_procedure_discovery.

Avoid these errors by switching to a temporary, non-repo directory
before running the tests.

Re: datalad#3029
Fixes datalad#3052.
@kyleam kyleam added the WIP label Jan 28, 2019
This can happen in at least one case where there isn't actually an
issue: when `datalad wtf` is called from a git worktree checkout of
the codebase.  And even if there is an issue, we should try to
describe as much as possible rather than aborting.
@kyleam kyleam force-pushed the tst-worktree-failures branch from 3727f6e to c358cf7 Jan 28, 2019
@kyleam
Copy link
Contributor Author

@kyleam kyleam commented Jan 28, 2019

Travis failures are the known crawler/neuroimaging failures, so all tests are green when executed from a worktree. I'll drop c358cf7.

@kyleam kyleam force-pushed the tst-worktree-failures branch from c358cf7 to b92ccce Jan 28, 2019
@codecov
Copy link

@codecov codecov bot commented Jan 28, 2019

Codecov Report

Merging #3129 into master will decrease coverage by 0.05%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3129      +/-   ##
==========================================
- Coverage   90.67%   90.62%   -0.06%     
==========================================
  Files         248      248              
  Lines       32673    32681       +8     
==========================================
- Hits        29626    29616      -10     
- Misses       3047     3065      +18
Impacted Files Coverage Δ
datalad/interface/tests/test_run_procedure.py 100% <100%> (ø) ⬆️
datalad/distribution/tests/test_create_sibling.py 98.61% <100%> (ø) ⬆️
datalad/plugin/wtf.py 81.73% <60%> (-0.6%) ⬇️
datalad/__init__.py 90.24% <0%> (-1.63%) ⬇️
datalad/utils.py 86.6% <0%> (-0.89%) ⬇️
datalad/distribution/create_sibling.py 85.09% <0%> (-0.67%) ⬇️
datalad/ui/dialog.py 92.54% <0%> (-0.63%) ⬇️
datalad/config.py 98.41% <0%> (-0.4%) ⬇️
datalad/support/annexrepo.py 88.4% <0%> (-0.3%) ⬇️
datalad/interface/run_procedure.py 89.3% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e37f0b...b92ccce. Read the comment docs.

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Jan 28, 2019

Thanks! I also kept running into it from time to time.

ah, indeed -- that @mih didn't listed my begging crawler is now indeed screwed up and needs probably a release but can't be released without datalad release... so I guess I would need to just revert some changes.
neuroimaging is awaiting feedback on datalad/datalad-neuroimaging#51

but what is up with appveyor? it seemed to be happy only 6 days ago ... I guess with new annex release (cmd:annex: 7.20190122-gc94b3a389) change of behavior so our basic test on install /// started to fail :-/ heheh filed #3130

@yarikoptic yarikoptic merged commit 30fb6fe into datalad:master Jan 28, 2019
1 of 3 checks passed
@kyleam kyleam deleted the tst-worktree-failures branch Jan 28, 2019
yarikoptic added a commit that referenced this issue Feb 8, 2019
 A variety of bugfixes and enhancements

 ### Major refactoring and deprecations

 - All extracted metadata is now placed under git-annex by default.
   Previously files smaller than 20 kb were stored in git. ([#3109])
 - TODO: get_runner #3104 and pending #3131

 ### Fixes

 - Improved handling of long commands:
   - The code that inspected `SC_ARG_MAX` didn't check that the
     reported value was a sensible, positive number. ([#3025])
   - More commands that invoke `git` and `git-annex` with file
     arguments learned to split up the command calls when it is likely
     that the command would fail due to exceeding the maximum supported
     length. ([#3138])
 - The `setup_yoda_dataset` procedure created a malformed
   .gitattributes line. ([#3057])
 - [download-url] unnecessarily tried to infer the dataset when
   `--no-save` was given. ([#3029])
 - [rerun] aborted too late and with a confusing message when a ref
   specified via `--onto` didn't exist. ([#3019])
 - [run]:
   - `run` didn't preserve the current directory prefix ("./") on
      inputs and outputs, which is problematic if the caller relies on
      this representation when formatting the command. ([#3037])
   - Fixed a number of unicode py2-compatibility issues. ([#3035]) ([#3046])
   - To proceed with a failed command, the user was confusingly
     instructed to use `save` instead of `add` even though `run` uses
     `add` underneath. ([#3080])
 - Fixed a case where the helper class for checking external modules
   incorrectly reported a module as unknown. ([#3051])
 - [add-archive-content] mishandled the archive path when the leading
   path contained a symlink. ([#3058])
 - Following denied access, the credential code failed to consider a
   scenario, leading to a type error rather than an appropriate error
   message. ([#3091])
 - Some tests failed when executed from a `git worktree` checkout of the
   source repository. ([#3129])
 - During metadata extraction, batched annex processes weren't properly
   terminated, leading to issues on Windows. ([#3137])
 - [add] incorrectly handled an "invalid repository" exception when
   trying to add a submodule. ([#3141])
 - Pass `GIT_SSH_VARIANT=ssh` to git processes to be able to specify
   alternative ports in SSH urls

 ### Enhancements and new features

 - [search] learned to suggest closely matching keys if there are no
   hits. ([#3089])
 - [create-sibling] gained a `--group` option so that the caller can
   specify the file system group for the repository. ([#3098])
 - Interface classes can now override the default renderer for
   summarizing results. ([#3061])
 - [run]:
   - `--input` and `--output` can now be shortened to `-i` and `-o`.
     ([#3066])
   - Placeholders such as "{inputs}" are now expanded in the command
     that is shown in the commit message subject. ([#3065])
   - `interface.run.run_command` gained an `extra_inputs` argument so
     that wrappers like [datalad-container] can specify additional inputs
     that aren't considered when formatting the command string. ([#3038])
   - "--" can now be used to separate options for `run` and those for
     the command in ambiguous cases. ([#3119])
 - The utilities `create_tree` and `ok_file_has_content` now support
   ".gz" files. ([#3049])
 - The Singularity container for 0.11.1 now uses [nd_freeze] to make
   its builds reproducible.
 - A [publications] page has been added to the documentation. ([#3099])
 - `GitRepo.set_gitattributes` now accepts a `mode` argument that
   controls whether the .gitattributes file is appended to (default) or
   overwritten. ([#3115])
 - `datalad --help` now avoids using `man` so that the list of
   subcommands is shown.  ([#3124])

* tag '0.11.2': (124 commits)
  Changelog entry for GIT_SSH_VARIANT change
  ENH: Declare our GIT_SSH_COMMAND as GIT_SSH_VARIANT=ssh
  BF: sshconnector: Don't use ssh's port flag as scp's
  RF: sshconnector: Simplify shlex quote import
  CHANGELOG(0.11.2): Fix some typos
  [DATALAD RUNCMD] CHANGELOG: Linkify 0.11.2 entries
  CHANGELOG: Do first pass for 0.11.2
  CHANGELOG: Add missing link target for download-url
  Start cooking the 0.11.2 release
  RF: appveyor - move test_install tests to be ran the last
  RF: text_type instead of str
  ENH(TST): provide my timing for the slow test
  BF(TST): adjust the test for the fact that AnnexRepo.add does not blow on nonexisting files
  ENH(TST): two tests which test quick or thorough for add failing with too long list of files
  BF: get stderr if present, otherwise just use str(e)
  BF: append out/err only if not empty/None
  Centrlize handling running commands with long files list in _run_command_files_split
  RF: remove minor duplication of -- handling, place all files handling closer to the call
  RF: move unrelated to try/except handling outside
  ENH+DOC: Report actual process handle, not just PID
  ...
@yarikoptic yarikoptic added this to the Release 0.11.2 milestone Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants