Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python information to "datalad wtf" command #3255

Merged
merged 2 commits into from Mar 21, 2019

Conversation

@driusan
Copy link
Collaborator

@driusan driusan commented Mar 21, 2019

datalad wtf did not include any information about which
version of Python is being used. This adds a section to
include the python version number and python implementation
being used to run datalad to aid in debugging.

datalad wtf did not include any information about which
version of Python is being used. This adds a section to
include the python version number and python implementation
being used to run datalad to aid in debugging.
@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Mar 21, 2019

Who said "elephant"? ;-) Thanks @driusan . FWIW, here is what I see

## python 
  - implementation: CPython
  - python: 2.7.14+

may be change "python" item to "version"? ;)

@codecov
Copy link

@codecov codecov bot commented Mar 21, 2019

Codecov Report

Merging #3255 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3255      +/-   ##
==========================================
- Coverage   91.04%   90.98%   -0.07%     
==========================================
  Files         263      263              
  Lines       34131    34135       +4     
==========================================
- Hits        31076    31057      -19     
- Misses       3055     3078      +23
Impacted Files Coverage Δ
datalad/plugin/wtf.py 82.06% <100%> (+0.32%) ⬆️
datalad/downloaders/tests/test_http.py 88.86% <0%> (-3.47%) ⬇️
datalad/downloaders/http.py 82.53% <0%> (-3.18%) ⬇️
datalad/downloaders/base.py 80.72% <0%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c753c8...b0c9962. Read the comment docs.

@driusan
Copy link
Collaborator Author

@driusan driusan commented Mar 21, 2019

Sure, I changed the key to "version"

@yarikoptic yarikoptic merged commit 4bc1367 into datalad:master Mar 21, 2019
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants