RF: Move the availability check for git-annex all the way to the end #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rational: We otherwise refuse to do anything with repos that could have an annex, but for operations like `status` this is not needed. Doing a late check will enable (more) datalad use on systems that do not have git-annex.
Codecov Report
@@ Coverage Diff @@
## master #3274 +/- ##
==========================================
- Coverage 91.02% 91.01% -0.02%
==========================================
Files 263 263
Lines 34132 34132
==========================================
- Hits 31069 31065 -4
- Misses 3063 3067 +4
Continue to review full report at Codecov.
|
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational: We otherwise refuse to do anything with repos that could have an annex, but for operations like
statusthis is not needed. Doing a late check will enable (more) datalad use on systems that do not havegit-annex.
@effigies wondered if it was possible to get information on a dataset without git-annex. This would be step one. It might be useful in this context to replace
AnnexRepo.get_content_annexinfo()to not callgit-annex find/findref, but to inspect the keys in a dataset on its own. This would makestatus --annex <mode>work without git-annex for any query mode where we would want to support this. It would also be straightforward to support a fallback that is only used when git-annex is actually not around.