Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Move the availability check for git-annex all the way to the end #3274

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@mih
Copy link
Member

@mih mih commented Mar 27, 2019

Rational: We otherwise refuse to do anything with repos that could have an annex, but for operations like status this is not needed. Doing a late check will enable (more) datalad use on systems that do not have
git-annex.

@effigies wondered if it was possible to get information on a dataset without git-annex. This would be step one. It might be useful in this context to replace AnnexRepo.get_content_annexinfo() to not call git-annex find/findref, but to inspect the keys in a dataset on its own. This would make status --annex <mode> work without git-annex for any query mode where we would want to support this. It would also be straightforward to support a fallback that is only used when git-annex is actually not around.

Rational: We otherwise refuse to do anything with repos that could have
an annex, but for operations like `status` this is not needed. Doing a
late check will enable (more) datalad use on systems that do not have
git-annex.
@codecov
Copy link

@codecov codecov bot commented Mar 27, 2019

Codecov Report

Merging #3274 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3274      +/-   ##
==========================================
- Coverage   91.02%   91.01%   -0.02%     
==========================================
  Files         263      263              
  Lines       34132    34132              
==========================================
- Hits        31069    31065       -4     
- Misses       3063     3067       +4
Impacted Files Coverage Δ
datalad/support/annexrepo.py 87.86% <100%> (ø) ⬆️
datalad/support/tests/test_annexrepo.py 96.39% <0%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52719b0...a3d1128. Read the comment docs.

@yarikoptic yarikoptic merged commit 84c36ec into datalad:master Mar 27, 2019
5 checks passed
@effigies
Copy link
Contributor

@effigies effigies commented Mar 27, 2019

🎉

@mih mih deleted the rf-lateannexcheck branch Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants