Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Make AnnexRepo.set_metadata() work without iteration #3298

Merged
merged 2 commits into from Apr 8, 2019

Conversation

@mih
Copy link
Member

@mih mih commented Apr 7, 2019

Analog to function like add/add_ the normal version now just does things, whereas the _ version returns a generator that needs to be iterator over to actually perform anything. The prior behavior was
a constant source of surprise and anger.

Related to #2755

mih added 2 commits Apr 7, 2019
Analog to function like add/add_ the normal version now just does
things, whereas the _ version returns a generator that needs to be
iterator over to actually perform anything. The prior behavior was
a constant source of surprise and anger.
@codecov
Copy link

@codecov codecov bot commented Apr 7, 2019

Codecov Report

Merging #3298 into master will increase coverage by 28.52%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3298       +/-   ##
===========================================
+ Coverage   62.51%   91.03%   +28.52%     
===========================================
  Files         100      263      +163     
  Lines       15410    34180    +18770     
===========================================
+ Hits         9633    31117    +21484     
+ Misses       5777     3063     -2714
Impacted Files Coverage Δ
datalad/support/tests/test_annexrepo.py 96.39% <100%> (ø)
datalad/metadata/tests/test_search.py 93.43% <100%> (ø)
datalad/support/annexrepo.py 87.96% <100%> (+34.59%) ⬆️
datalad/plugin/tests/test_addurls.py 100% <100%> (ø)
datalad/plugin/addurls.py 99.68% <100%> (+81.36%) ⬆️
datalad/metadata/__init__.py 100% <0%> (ø) ⬆️
datalad/downloaders/tests/utils.py 92.3% <0%> (ø)
datalad/customremotes/tests/__init__.py 100% <0%> (ø)
datalad/cmdline/tests/test_helpers.py 100% <0%> (ø)
datalad/support/tests/test_stats.py 100% <0%> (ø)
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b0e8e...097a84d. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Apr 7, 2019

Codecov Report

Merging #3298 into master will increase coverage by 25.04%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3298       +/-   ##
===========================================
+ Coverage   62.51%   87.55%   +25.04%     
===========================================
  Files         100      263      +163     
  Lines       15410    34176    +18766     
===========================================
+ Hits         9633    29922    +20289     
+ Misses       5777     4254     -1523
Impacted Files Coverage Δ
datalad/plugin/tests/test_addurls.py 59.31% <0%> (ø)
datalad/plugin/addurls.py 72.98% <0%> (+54.65%) ⬆️
datalad/support/tests/test_annexrepo.py 95.36% <100%> (ø)
datalad/metadata/tests/test_search.py 93.43% <100%> (ø)
datalad/support/annexrepo.py 87.01% <100%> (+33.64%) ⬆️
datalad/downloaders/tests/utils.py 92.3% <0%> (ø)
datalad/customremotes/tests/__init__.py 100% <0%> (ø)
datalad/cmdline/tests/test_helpers.py 100% <0%> (ø)
datalad/support/tests/test_stats.py 100% <0%> (ø)
datalad/tests/test_utils.py 96.85% <0%> (ø)
... and 228 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b0e8e...097a84d. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Apr 8, 2019

I suspect this is non-controversial.

@mih mih merged commit 7653e0d into datalad:master Apr 8, 2019
5 checks passed
@mih mih deleted the rf-metaset branch Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant