Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Report 'bytesize' from plain Git, whenever ls-tree runs anyways #3299

Merged
merged 3 commits into from Apr 8, 2019

Conversation

mih
Copy link
Member

@mih mih commented Apr 7, 2019

It is cheap and useful.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to make code easier to read and more robust - named groups in regular expression

datalad/support/gitrepo.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #3299 into master will increase coverage by 28.52%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3299       +/-   ##
===========================================
+ Coverage   62.51%   91.03%   +28.52%     
===========================================
  Files         100      263      +163     
  Lines       15410    34189    +18779     
===========================================
+ Hits         9633    31125    +21492     
+ Misses       5777     3064     -2713
Impacted Files Coverage Δ
datalad/core/local/tests/test_status.py 98.86% <100%> (ø)
datalad/support/tests/test_fileinfo.py 100% <100%> (ø)
datalad/support/gitrepo.py 88.91% <90.9%> (+16.87%) ⬆️
datalad/metadata/__init__.py 100% <0%> (ø) ⬆️
datalad/downloaders/tests/utils.py 92.3% <0%> (ø)
datalad/customremotes/tests/__init__.py 100% <0%> (ø)
datalad/cmdline/tests/test_helpers.py 100% <0%> (ø)
datalad/support/tests/test_stats.py 100% <0%> (ø)
datalad/tests/test_utils.py 96.85% <0%> (ø)
datalad/metadata/extractors/__init__.py 100% <0%> (ø)
... and 228 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b0e8e...4d8d948. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #3299 into master will decrease coverage by 11.95%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3299       +/-   ##
===========================================
- Coverage   62.51%   50.55%   -11.96%     
===========================================
  Files         100      263      +163     
  Lines       15410    34171    +18761     
===========================================
+ Hits         9633    17276     +7643     
- Misses       5777    16895    +11118
Impacted Files Coverage Δ
datalad/core/local/tests/test_status.py 22.72% <0%> (ø)
datalad/support/gitrepo.py 72.98% <90%> (+0.94%) ⬆️
datalad/downloaders/tests/utils.py 84.61% <0%> (ø)
datalad/customremotes/tests/__init__.py 33.33% <0%> (ø)
datalad/cmdline/tests/test_helpers.py 32.69% <0%> (ø)
datalad/support/tests/test_stats.py 13.11% <0%> (ø)
datalad/tests/test_utils.py 19.56% <0%> (ø)
datalad/metadata/extractors/__init__.py 100% <0%> (ø)
datalad/distribution/tests/test_dataset_binding.py 19.23% <0%> (ø)
datalad/tests/test_misc.py 38.09% <0%> (ø)
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b0e8e...4d8d948. Read the comment docs.

@mih mih merged commit cc3a9e6 into datalad:master Apr 8, 2019
@mih mih deleted the enh_bytesize branch April 8, 2019 06:44
mih added a commit to datalad/datalad-revolution that referenced this pull request Apr 8, 2019
mih added a commit to datalad/datalad-revolution that referenced this pull request Apr 8, 2019
mih added a commit to datalad/datalad-revolution that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants