ENH: AnnexRepo.get_metadata(batch=True) #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3364 +/- ##
==========================================
+ Coverage 91.15% 91.18% +0.02%
==========================================
Files 263 263
Lines 34196 34210 +14
==========================================
+ Hits 31172 31193 +21
+ Misses 3024 3017 -7
Continue to review full report at Codecov.
|
Can now be used with a generator as input and yields a generator as output.
without juggling data types and return values.
This is a fragile enterprise due to the limitations of
`BatchedCommand()`. When queried for a non-annexed file, git annex
will error not via JSON response, but through stderr
```
{"file": "."}
git-annex: not an annexed file: .
```
which ATM is not monitored at all. I assume due to the general
sadness of subprocess under PY2.
Docstrings warn about this, there is no `batch=None` automagic because
of this.
Other than that, is works.
|
Two things to fix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fragile enterprise due to the limitations of
BatchedCommand(). When queried for a non-annexed file, git annex will error not via JSON response, but through stderrwhich ATM is not monitored at all. I assume due to the general sadness of subprocess under PY2.
Docstrings warn about this, and there is no
batch=Noneautomagic because of this.Other than that, it works.
This is needed to achieve a sensible performance of the
annexextractor in -revolution (the behavior of the one in -core is pointless anyways), where all these limitation do not matter.Waiting here: https://github.com/datalad/datalad-revolution/compare/enh-annex