Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Various little annoyances in SSH support code #3400

Merged
merged 6 commits into from May 13, 2019
Merged

RF: Various little annoyances in SSH support code #3400

merged 6 commits into from May 13, 2019

Conversation

@mih
Copy link
Member

@mih mih commented May 11, 2019

  • stop use of /dev/null
  • stop unconditional use of POSIX path conventions
mih added 3 commits May 11, 2019
Simplifies some code, remove *NIX platform assumptions in other places.
@mih mih changed the title WIP RF: Various little annoyances in SSH support code RF: Various little annoyances in SSH support code May 11, 2019
mih and others added 2 commits May 11, 2019
This was dropped in the previous commit, but, as mentioned in the
comment above the import and as failing tests show, other modules
expect it to be present.
@codecov
Copy link

@codecov codecov bot commented May 12, 2019

Codecov Report

Merging #3400 into master will decrease coverage by 32.48%.
The diff coverage is 62.16%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3400       +/-   ##
===========================================
- Coverage   91.26%   58.78%   -32.49%     
===========================================
  Files         265      265               
  Lines       34360    34345       -15     
===========================================
- Hits        31360    20190    -11170     
- Misses       3000    14155    +11155
Impacted Files Coverage Δ
datalad/support/sshrun.py 79.41% <100%> (-17.56%) ⬇️
datalad/support/tests/test_gitrepo.py 17.56% <25%> (-82.32%) ⬇️
datalad/support/tests/test_sshconnector.py 45.83% <30%> (-53.47%) ⬇️
datalad/support/tests/test_annexrepo.py 17.74% <33.33%> (-78.28%) ⬇️
datalad/support/sshconnector.py 68.31% <88.88%> (-16.71%) ⬇️
datalad/support/tests/test_fileinfo.py 12.24% <0%> (-87.76%) ⬇️
datalad/support/tests/utils.py 13.04% <0%> (-86.96%) ⬇️
datalad/support/tests/test_repodates.py 13.46% <0%> (-86.54%) ⬇️
datalad/cmdline/tests/test_formatters.py 14.28% <0%> (-85.72%) ⬇️
datalad/interface/tests/test_save.py 14.66% <0%> (-85.34%) ⬇️
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b908e6...c549fe0. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented May 12, 2019

Codecov Report

Merging #3400 into master will increase coverage by 0.02%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3400      +/-   ##
==========================================
+ Coverage   91.26%   91.28%   +0.02%     
==========================================
  Files         265      265              
  Lines       34360    34360              
==========================================
+ Hits        31360    31367       +7     
+ Misses       3000     2993       -7
Impacted Files Coverage Δ
datalad/support/tests/test_gitrepo.py 99.88% <100%> (ø) ⬆️
datalad/support/tests/test_sshconnector.py 99.3% <100%> (ø) ⬆️
datalad/support/tests/test_annexrepo.py 96.01% <100%> (ø) ⬆️
datalad/support/sshrun.py 97.05% <100%> (+0.08%) ⬆️
datalad/support/sshconnector.py 84.65% <88.88%> (-0.38%) ⬇️
datalad/downloaders/http.py 86.5% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b908e6...87f5eb4. Read the comment docs.

This test code could instead be adjusted to use the pathlib interface,
but doing that is more work.
@mih
Copy link
Member Author

@mih mih commented May 12, 2019

Thx @kyleam !

@mih mih merged commit 8872d25 into datalad:master May 13, 2019
5 checks passed
@mih mih deleted the rf-ssh branch May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants