Move run (and some run tests) into core/local #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move run into the location proposed by dataladgh-3192. For now, keep the old module around for compatibility, particularly with extensions. Following the approach of a290c7b, use the warnings module rather than logging to warn about use of the obsolete module. (Note, though, that a DeprecationWarning is used, and warnings in that category aren't shown by default.) Closes datalad#3434.
The run module is now in core.local. We can't move all the run tests
to core.local because many of them also test rerun, but move the ones
that don't test rerun.
As shown by
git show --no-renames --color-moved ...
there are no changes to any tests.
|
Yeah! Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly pure code movement, which is probably easiest to review with
git log --no-renames --color-moved=dimmed_zebra -p ....