Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move run (and some run tests) into core/local #3444

Merged
merged 3 commits into from May 22, 2019
Merged

Conversation

@kyleam
Copy link
Contributor

@kyleam kyleam commented May 21, 2019

This is mostly pure code movement, which is probably easiest to review with git log --no-renames --color-moved=dimmed_zebra -p ....

kyleam added 3 commits May 21, 2019
Move run into the location proposed by dataladgh-3192.

For now, keep the old module around for compatibility, particularly
with extensions.  Following the approach of a290c7b, use the
warnings module rather than logging to warn about use of the obsolete
module.  (Note, though, that a DeprecationWarning is used, and
warnings in that category aren't shown by default.)

Closes datalad#3434.
The run module is now in core.local.  We can't move all the run tests
to core.local because many of them also test rerun, but move the ones
that don't test rerun.

As shown by

    git show --no-renames --color-moved ...

there are no changes to any tests.
@mih
Copy link
Member

@mih mih commented May 22, 2019

Yeah! Thx!

@mih mih merged commit ce9c8b1 into datalad:master May 22, 2019
3 checks passed
@kyleam kyleam deleted the move-run branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants