Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh bring gc back #3458

Merged
merged 1 commit into from May 31, 2019
Merged

Enh bring gc back #3458

merged 1 commit into from May 31, 2019

Conversation

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented May 24, 2019

Closes #3457 if we decide to go for it

@kyleam kyleam changed the base branch from master to 0.11.x May 24, 2019
@kyleam kyleam mentioned this pull request May 24, 2019
@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented May 24, 2019

So only neuroimaging expected failure.. hm... Will rerun it a few times later when after neuroimaging

@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented May 24, 2019

appveyor failure might be "legit"... restarted

@codecov
Copy link

@codecov codecov bot commented May 24, 2019

Codecov Report

Merging #3458 into 0.11.x will increase coverage by 1.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.11.x    #3458      +/-   ##
==========================================
+ Coverage   91.01%   92.05%   +1.04%     
==========================================
  Files         255      273      +18     
  Lines       33493    43916   +10423     
==========================================
+ Hits        30484    40429    +9945     
- Misses       3009     3487     +478
Impacted Files Coverage Δ
datalad/support/gitrepo.py 91.01% <100%> (+1.88%) ⬆️
datalad/support/cookies.py 76.27% <0%> (-8.48%) ⬇️
datalad/interface/ls.py 62.88% <0%> (-5.95%) ⬇️
datalad/interface/unlock.py 91.39% <0%> (-3.67%) ⬇️
datalad/downloaders/http.py 82.53% <0%> (-2.78%) ⬇️
datalad/tests/test_version.py 67.5% <0%> (-2.78%) ⬇️
datalad/support/annexrepo.py 86.58% <0%> (-2.41%) ⬇️
datalad/interface/save.py 86.53% <0%> (-2.36%) ⬇️
datalad/distribution/tests/test_add.py 81.08% <0%> (-1.88%) ⬇️
datalad/plugin/tests/test_export_archive.py 98.64% <0%> (-1.36%) ⬇️
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3d96a...203aa65. Read the comment docs.

@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented May 30, 2019

I have reran travis a few times and it seems to show no bad signs... should we merge?

@kyleam
Copy link
Contributor

@kyleam kyleam commented May 30, 2019

should we merge?

I think so. Easy enough to revert if the issues pop up again.

@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented May 31, 2019

ok, let's see what would happen ;)

@yarikoptic yarikoptic merged commit e6fe78f into datalad:0.11.x May 31, 2019
5 checks passed
@yarikoptic yarikoptic deleted the enh-bring-gc-back branch Jun 3, 2019
@yarikoptic yarikoptic added this to the Release 0.11.6 milestone Jul 26, 2019
yarikoptic added a commit that referenced this issue Jul 31, 2019
0.11.6 (Jul 30, 2019) -- am I the last of 0.11.x?

Primarily bug fixes to achieve more robust performance

Fixes

- Our tests needed various adjustments to keep up with upstream
  changes in Travis and Git. ([#3479][]) ([#3492][]) ([#3493][])

- `AnnexRepo.is_special_annex_remote` was too selective in what it
  considered to be a special remote.  ([#3499][])

- We now provide information about unexpected output when git-annex is
  called with `--json`.  ([#3516][])

- Exception logging in the `__del__` method of `GitRepo` and
  `AnnexRepo` no longer fails if the names it needs are no longer
  bound.  ([#3527][])

- [addurls][] botched the construction of subdataset paths that were
  more than two levels deep and failed to create datasets in a
  reliable, breadth-first order.  ([#3561][])

- Cloning a `type=git` special remote showed a spurious warning about
  the remote not being enabled.  ([#3547][])

Enhancements and new features

- For calls to git and git-annex, we disable automatic garbage
  collection due to past issues with GitPython's state becoming stale,
  but doing so results in a larger .git/objects/ directory that isn't
  cleaned up until garbage collection is triggered outside of DataLad.
  Tests with the latest GitPython didn't reveal any state issues, so
  we've re-enabled automatic garbage collection.  ([#3458][])

- [rerun][] learned an `--explicit` flag, which it relays to its calls
  to [run][[]].  This makes it possible to call `rerun` in a dirty
  working tree ([#3498][]).

- The [metadata][] command aborts earlier if a metadata extractor is
  unavailable.  ([#3525][])

* tag '0.11.6': (56 commits)
  [DATALAD RUNCMD] make update-changelog
  finalize CHANGELOG.md entry and boost version
  BF(DOC): close [create] with [] to not cause WARNING by md-strict pandoc
  CHANGELOG.md: Link entry from b3e8adb
  CHANGELOG.md: Add entry for gh-3547
  CHANGELOG.md: Add entry for gh-3561
  CHANGELOG.md: Add link for addurls
  RF: inform about special remotes based on autoenable config
  CHANGELOG.md: Second batch for 0.11.6
  BF: addurls: Process datasets in a stable, breadth-first order
  BF: addurls: Fix construction of nested subpaths
  TST: addurls: Don't hard-code path separator
  BF(TST): skip test_v7_detached_get in direct mode - fails to annex upgrade
  TST: benchmark-travis-pr: Swap 'pip install' and 'git show'
  TST: benchmark-travis-pr: Move repeated logic to run_asv()
  TST: benchmark-travis-pr: Support other bases
  TST: benchmark-travis-pr: Tweak message about current HEAD
  TST: benchmark-travis-pr: Simplify two git commands into one
  TST: benchmark-travis-pr: Reorder and break up lines
  TST: benchmark-travis-pr: Move command for running asv into function
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants