Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: travis: Drop "-dev" suffix from py3.7 build #3479

Merged
merged 1 commit into from Jun 13, 2019

Conversation

@kyleam
Copy link
Contributor

@kyleam kyleam commented Jun 13, 2019

When Travis switched its default distribution from Trusty to Xenial,
our 3.7-dev build started to error with a segfault. The reason for
this isn't clear, but a plain 3.7 build doesn't 0 show the segfault,
so let's use that instead.

Fixes #3477.

When Travis switched its default distribution from Trusty to Xenial,
our 3.7-dev build started to error with a segfault.  The reason for
this isn't clear, but a plain 3.7 build doesn't [0] show the segfault,
so let's use that instead.

[0]: https://travis-ci.org/datalad/datalad/builds/545360524

Fixes datalad#3477.
@codecov
Copy link

@codecov codecov bot commented Jun 13, 2019

Codecov Report

Merging #3479 into 0.11.x will decrease coverage by 9.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.11.x    #3479      +/-   ##
==========================================
- Coverage   91.04%   81.49%   -9.55%     
==========================================
  Files         255      252       -3     
  Lines       33496    33486      -10     
==========================================
- Hits        30495    27288    -3207     
- Misses       3001     6198    +3197
Impacted Files Coverage Δ
datalad/cmdline/tests/test_formatters.py 14.28% <0%> (-85.72%) ⬇️
datalad/plugin/addurls.py 18.32% <0%> (-81.37%) ⬇️
datalad/interface/rerun.py 18.48% <0%> (-77.73%) ⬇️
datalad/plugin/export_archive.py 24.65% <0%> (-75.35%) ⬇️
datalad/support/due_utils.py 16.27% <0%> (-74.42%) ⬇️
datalad/distribution/publish.py 16.42% <0%> (-71.43%) ⬇️
datalad/plugin/add_readme.py 29.31% <0%> (-63.8%) ⬇️
datalad/support/strings.py 28% <0%> (-60%) ⬇️
datalad/interface/download_url.py 37.83% <0%> (-59.46%) ⬇️
datalad/distribution/create_sibling.py 26.64% <0%> (-59.25%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fe78f...1832da8. Read the comment docs.

@kyleam
Copy link
Contributor Author

@kyleam kyleam commented Jun 13, 2019

OK, will merge to get test suite into a passing state. We can tweak it later if someone thinks we should go a different route.

@kyleam kyleam merged commit 1832da8 into datalad:0.11.x Jun 13, 2019
4 of 5 checks passed
@kyleam kyleam deleted the travis-drop-37-dev branch Jun 13, 2019
yarikoptic
Copy link
Member

yarikoptic commented on 1832da8 Jun 13, 2019

Woohoo, thanks

@yarikoptic yarikoptic added this to the Release 0.11.6 milestone Jul 26, 2019
yarikoptic added a commit that referenced this issue Jul 31, 2019
0.11.6 (Jul 30, 2019) -- am I the last of 0.11.x?

Primarily bug fixes to achieve more robust performance

Fixes

- Our tests needed various adjustments to keep up with upstream
  changes in Travis and Git. ([#3479][]) ([#3492][]) ([#3493][])

- `AnnexRepo.is_special_annex_remote` was too selective in what it
  considered to be a special remote.  ([#3499][])

- We now provide information about unexpected output when git-annex is
  called with `--json`.  ([#3516][])

- Exception logging in the `__del__` method of `GitRepo` and
  `AnnexRepo` no longer fails if the names it needs are no longer
  bound.  ([#3527][])

- [addurls][] botched the construction of subdataset paths that were
  more than two levels deep and failed to create datasets in a
  reliable, breadth-first order.  ([#3561][])

- Cloning a `type=git` special remote showed a spurious warning about
  the remote not being enabled.  ([#3547][])

Enhancements and new features

- For calls to git and git-annex, we disable automatic garbage
  collection due to past issues with GitPython's state becoming stale,
  but doing so results in a larger .git/objects/ directory that isn't
  cleaned up until garbage collection is triggered outside of DataLad.
  Tests with the latest GitPython didn't reveal any state issues, so
  we've re-enabled automatic garbage collection.  ([#3458][])

- [rerun][] learned an `--explicit` flag, which it relays to its calls
  to [run][[]].  This makes it possible to call `rerun` in a dirty
  working tree ([#3498][]).

- The [metadata][] command aborts earlier if a metadata extractor is
  unavailable.  ([#3525][])

* tag '0.11.6': (56 commits)
  [DATALAD RUNCMD] make update-changelog
  finalize CHANGELOG.md entry and boost version
  BF(DOC): close [create] with [] to not cause WARNING by md-strict pandoc
  CHANGELOG.md: Link entry from b3e8adb
  CHANGELOG.md: Add entry for gh-3547
  CHANGELOG.md: Add entry for gh-3561
  CHANGELOG.md: Add link for addurls
  RF: inform about special remotes based on autoenable config
  CHANGELOG.md: Second batch for 0.11.6
  BF: addurls: Process datasets in a stable, breadth-first order
  BF: addurls: Fix construction of nested subpaths
  TST: addurls: Don't hard-code path separator
  BF(TST): skip test_v7_detached_get in direct mode - fails to annex upgrade
  TST: benchmark-travis-pr: Swap 'pip install' and 'git show'
  TST: benchmark-travis-pr: Move repeated logic to run_asv()
  TST: benchmark-travis-pr: Support other bases
  TST: benchmark-travis-pr: Tweak message about current HEAD
  TST: benchmark-travis-pr: Simplify two git commands into one
  TST: benchmark-travis-pr: Reorder and break up lines
  TST: benchmark-travis-pr: Move command for running asv into function
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants