TST: annexrepo: Update test for "no commits" sub-repo fix in Git

[kyleam]

As of Git 2.22.0, specifically b22827045e (dir: do not traverse
repositories with no commits, 2019-04-09), 'git ls-files' now treats a
repository on an unborn branch as a repository rather than a
directory.

Fixes #3490.

[kyleam]

A Git v2.22.0 build (with this PR and gh-3492) is set up at: https://travis-ci.org/datalad/datalad/builds/550858203

[kyleam]

The updated test fails in the 2.22.0 Travis build. I'm afraid this is due to the same issue I haven't figured out in gh-3476. When I run it locally, both Git 2.21.0 and 2.22.0 behave as expected. For 2.22.0, this means that "submod/" is included in the untracked files, the same result that the azure build posted in gh-3490 shows.

So my local tests and conda's azure tests agree. There seems to be something wonky with the upstream Git setup on Travis.

[kyleam]

So my local tests and conda's azure tests agree. There seems to be something wonky with the upstream Git setup on Travis.

Or, somehow the bundled Git is getting used despite setting DATALAD_USE_DEFAULT_GIT=1. I switched to git-annex-standalone from neurodebian, and I can trigger this. That gives me something to dig into locally.

failure

% DATALAD_USE_DEFAULT_GIT=1 python -m nose datalad/support/tests/test_annexrepo.py:test_AnnexRepo_status
F
======================================================================
FAIL: datalad.support.tests.test_annexrepo.test_AnnexRepo_status
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/kyle/src/python/venvs/datalad/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/kyle/src/python/datalad/datalad/tests/utils.py", line 615, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "/home/kyle/src/python/datalad/datalad/tests/utils.py", line 615, in newfunc
    return t(*(arg + (filename,)), **kw)
  File "/home/kyle/src/python/datalad/datalad/support/tests/test_annexrepo.py", line 2153, in test_AnnexRepo_status
    _test_status(ar)
  File "/home/kyle/src/python/datalad/datalad/support/tests/test_annexrepo.py", line 1996, in _test_status
    eq_(stat, ar.get_status())
AssertionError: {'type_changed': [], 'added': [], 'untracked': ['fifth', 'sub/third', 'submod/'], 'modified': ['first', 'second'], 'deleted': []} != {'type_changed': [], 'added': [], 'untracked': ['fifth', 'sub/third'], 'modified': ['first', 'second'], 'deleted': []}
-------------------- >> begin captured logging << --------------------
datalad.utils: Level 5: Importing datalad.utils
datalad.utils: DEBUG: Maximal length of cmdline string (adjusted for safety margin): 1252864
datalad.utils: Level 5: Done importing datalad.utils
datalad.cmd: Level 9: Will use default git /home/kyle/.guix-profile/bin/git
datalad.cmd: Level 9: Running: ['git', 'version']
datalad.cmd: Level 8: Finished running ['git', 'version'] with status 0
datalad.cmd: Level 9: Running: ['git', 'config', '-z', '-l', '--show-origin']
datalad.cmd: Level 8: Finished running ['git', 'config', '-z', '-l', '--show-origin'] with status 0
datalad.ui: Level 5: Starting importing ui
datalad.ui.dialog: Level 5: Starting importing ui.dialog
datalad.ui.dialog: Level 5: Done importing ui.dialog
datalad.ui: Level 5: Initiating UI switcher
datalad.ui: DEBUG: UI set to SilentConsoleLog(out=<StringIO>)
datalad.ui: Level 5: Done importing ui
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 1 test in 1.797s

FAILED (failures=1)

[kyleam]

Or, somehow the bundled Git is getting used despite setting `DATALAD_USE_DEFAULT_GIT=1`.

In the case of test_AnnexRepo_status, the bundled git was being accessed through `git annex status`. I've worked around this by adding an entry for the bundled git to external_versions, and then having the test look at that to decide what status output it expects. The test run with the upstream Git is now green (aside from the ls_webui error fixed by gh-3492), so I'll drop c4bb132. https://travis-ci.org/datalad/datalad/builds/550960613

[kyleam]

The appveyor failures are the familiar test_install.test_datasets_datalad_org failures.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (0.11.x@27b9aa4). Click here to learn what that means.
The diff coverage is 76.92%.

@@            Coverage Diff            @@
##             0.11.x    #3493   +/-   ##
=========================================
  Coverage          ?   77.41%           
=========================================
  Files             ?      252           
  Lines             ?    33507           
  Branches          ?        0           
=========================================
  Hits              ?    25941           
  Misses            ?     7566           
  Partials          ?        0

Impacted Files	Coverage Δ
datalad/support/external_versions.py	75.55% <100%> (ø)
datalad/support/tests/test_annexrepo.py	96% <66.66%> (ø)
datalad/cmd.py	85.61% <88.88%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b9aa4...1cd955d. Read the comment docs.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (0.11.x@27b9aa4). Click here to learn what that means.
The diff coverage is 76.92%.

@@            Coverage Diff            @@
##             0.11.x    #3493   +/-   ##
=========================================
  Coverage          ?   77.41%           
=========================================
  Files             ?      252           
  Lines             ?    33507           
  Branches          ?        0           
=========================================
  Hits              ?    25941           
  Misses            ?     7566           
  Partials          ?        0

Impacted Files	Coverage Δ
datalad/support/external_versions.py	75.55% <100%> (ø)
datalad/support/tests/test_annexrepo.py	96% <66.66%> (ø)
datalad/cmd.py	85.61% <88.88%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b9aa4...1cd955d. Read the comment docs.

[kyleam]

Test with upstream Git looks good. AppVeyor failure is due to test_install.test_datasets_datalad_org. Will merge, dropping the last commit.