Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor status issues #3534

Merged
merged 4 commits into from Jul 17, 2019
Merged

Fix minor status issues #3534

merged 4 commits into from Jul 17, 2019

Conversation

@mih
Copy link
Member

@mih mih commented Jul 16, 2019

  • status --annex basic -> status --annex #3520
  • datalad status --annex basic fails with no-size URL-type keys #3519
mih and others added 4 commits Jul 16, 2019
Comes with no test, as all our tooling offers http servers
that report file size even for `git annex addurl --fast`
We would need to ping that 3rd-party file that is mentioned
in the tests, but I don't want to.
The import seems necessary for Sphinx to find the function. (`python
-m nose --with-doctest ...` works fine without it.)

<https://travis-ci.org/datalad/datalad/jobs/559347580#L1414>
@codecov
Copy link

@codecov codecov bot commented Jul 16, 2019

Codecov Report

Merging #3534 into master will decrease coverage by 4.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3534      +/-   ##
==========================================
- Coverage   83.01%   78.97%   -4.05%     
==========================================
  Files         272      272              
  Lines       35088    35081       -7     
==========================================
- Hits        29130    27705    -1425     
- Misses       5958     7376    +1418
Impacted Files Coverage Δ
datalad/core/local/status.py 98.79% <ø> (+2.96%) ⬆️
datalad/support/annexrepo.py 62.67% <40%> (-0.81%) ⬇️
datalad/utils.py 63.25% <76.92%> (-0.35%) ⬇️
datalad/interface/tests/test_annotate_paths.py 23.74% <0%> (-76.26%) ⬇️
datalad/plugin/wtf.py 19.08% <0%> (-57.27%) ⬇️
datalad/support/_lru_cache2.py 0% <0%> (-54.81%) ⬇️
datalad/support/third/loris_token_generator.py 42.85% <0%> (-47.62%) ⬇️
datalad/plugin/tests/test_addurls.py 59.31% <0%> (-40.69%) ⬇️
datalad/distribution/tests/test_get.py 60.29% <0%> (-39.71%) ⬇️
datalad/metadata/tests/test_base.py 60.56% <0%> (-38.74%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf6337...75e0b8d. Read the comment docs.

kyleam
kyleam approved these changes Jul 16, 2019
Copy link
Contributor

@kyleam kyleam left a comment

LGTM (assuming my push brings the tests to a passing state)

@mih mih merged commit f1d64b9 into datalad:master Jul 17, 2019
3 checks passed
@mih
Copy link
Member Author

@mih mih commented Jul 17, 2019

Thx @kyleam !

@mih mih deleted the enh-status-ux branch Jul 17, 2019
@yarikoptic yarikoptic added this to the Release 0.12.0 milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants