Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: addurls: Add --cfg-proc option that is passed to create() #3562

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@kyleam
Copy link
Contributor

@kyleam kyleam commented Jul 25, 2019

This allows callers to perform arbitrary configuration of the
generated datasets.


  • add test
@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Jul 26, 2019

FWIW looks good if works correctly ;)

This allows callers to perform arbitrary configuration of the
generated datasets.
@kyleam kyleam marked this pull request as ready for review Jul 26, 2019
@kyleam kyleam force-pushed the addurls-cfg-proc branch from 33dbd24 to cc28fd7 Jul 26, 2019
@codecov
Copy link

@codecov codecov bot commented Jul 26, 2019

Codecov Report

Merging #3562 into master will increase coverage by 38.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #3562       +/-   ##
==========================================
+ Coverage   44.36%     83%   +38.63%     
==========================================
  Files         269     272        +3     
  Lines       35157   35175       +18     
==========================================
+ Hits        15598   29196    +13598     
+ Misses      19559    5979    -13580
Impacted Files Coverage Δ
datalad/plugin/addurls.py 18.26% <ø> (ø) ⬆️
datalad/plugin/tests/test_addurls.py 100% <100%> (+100%) ⬆️
datalad/tests/test_dochelpers.py 100% <0%> (ø) ⬆️
tools/coverage-bin/git-annex-remote-datalad 100% <0%> (ø)
tools/coverage-bin/datalad 100% <0%> (ø)
...ols/coverage-bin/git-annex-remote-datalad-archives 100% <0%> (ø)
datalad/config.py 98.81% <0%> (+0.39%) ⬆️
datalad/core/local/tests/test_diff.py 99.4% <0%> (+0.59%) ⬆️
datalad/ui/progressbars.py 82.43% <0%> (+0.67%) ⬆️
datalad/support/json_py.py 98.86% <0%> (+1.13%) ⬆️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4a8b7...cc28fd7. Read the comment docs.

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Jul 26, 2019

Great, thanks!

@yarikoptic yarikoptic merged commit f275f4c into datalad:master Jul 26, 2019
5 checks passed
@kyleam kyleam deleted the addurls-cfg-proc branch Jul 26, 2019
@yarikoptic yarikoptic added this to the Release 0.12.0 milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants