RF: remove: Replace interface.save with core.local.save #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rev_save() has been promoted to save(), but there are still a few places where the obsolete save() is used. One of these spots is remove.py, where 1c49a1f (MNT: interface.save: Demote and mark obsolete, 2019-05-14) claimed the old save() is needed because annotated paths are passed as arguments. But instead of punting until annotate_paths() use is dropped from remove.py (dataladgh-3368), we can make the call compatible with the new save() by pulling out the paths from the annotated paths record. In addition to dropping the internal use of an obsolete command, this avoids spurious warnings about removed files not existing. Closes datalad#3441.
Given that we now call the Save() from core.local.save, which doesn't accept annotated paths, and that the goal is to rewrite remove() without annotate_paths() (dataladgh-3368), this to-do is no longer relevant. [ci skip]
Codecov Report
@@ Coverage Diff @@
## master #3586 +/- ##
==========================================
- Coverage 76.99% 76.99% -0.01%
==========================================
Files 272 272
Lines 35354 35354
==========================================
- Hits 27222 27221 -1
- Misses 8132 8133 +1
Continue to review full report at Codecov.
|
|
OK, the Travis build looks fine, and this is an easy revert if an issue pops up, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rev_save() has been promoted to save(), but there are still a few
places where the obsolete save() is used. One of these spots is
remove.py, where 1c49a1f (MNT: interface.save: Demote and mark
obsolete, 2019-05-14) claimed the old save() is needed because
annotated paths are passed as arguments. But instead of punting until
annotate_paths() use is dropped from remove.py (gh-3368), we can make
the call compatible with the new save() by pulling out the paths from
the annotated paths record.
In addition to dropping the internal use of an obsolete command, this
avoids spurious warnings about removed files not existing.
Closes #3441.
I didn't find any failures with selective testing locally. Let's see how the full Travis build goes.