Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: pass "paths" as "files" argument to _run...command for proper chunking #3587

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@yarikoptic
Copy link
Member

commented Aug 5, 2019

Otherwise long lists of full paths quickly cause "too long" crash.

Closes #3585

TODOs

  • verify nothing is broken in tests
  • see if helps in real-life
BF: pass "paths" as "files" argument to _run...command for proper chu…
…nking

Otherwise long lists of full paths quickly cause "too long" crash.
@kyleam
kyleam approved these changes Aug 5, 2019
Copy link
Member

left a comment

Good catch

@yarikoptic

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

for real-life -- I think it helped (didn't crash as fast), but there is something else which makes datalad very busy for very long, so I had to interrupt and rerun dumping logs into a file to possibly see where things are "busy".

@yarikoptic

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

it did help in RL, nothing seems to be broken, merging

@yarikoptic yarikoptic merged commit b7cfe69 into datalad:master Aug 7, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yarikoptic yarikoptic deleted the yarikoptic:bf-annex-cmd-files branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.