Fix gh-3621 broken error handling under PY3

[mih]

Pretty much just moving the affected code (see #3621). Plus replacement of import * usage.

Fingers crossed...

[codecov]

Codecov Report

Merging #3622 into master will decrease coverage by 58.07%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master    #3622       +/-   ##
===========================================
- Coverage   82.93%   24.85%   -58.08%     
===========================================
  Files         273      270        -3     
  Lines       35509    35492       -17     
===========================================
- Hits        29450     8823    -20627     
- Misses       6059    26669    +20610

Impacted Files	Coverage Δ
datalad/downloaders/s3.py	0% <0%> (-57.37%)	⬇️
datalad/downloaders/http.py	0% <0%> (-61.51%)	⬇️
datalad/downloaders/base.py	0% <0%> (-56.37%)	⬇️
datalad/customremotes/tests/__init__.py	0% <0%> (-100%)	⬇️
datalad/tests/test_protocols.py	0% <0%> (-100%)	⬇️
datalad/tests/test_constraints.py	0% <0%> (-100%)	⬇️
datalad/tests/test_misc.py	0% <0%> (-100%)	⬇️
datalad/distribution/tests/test_clone.py	0% <0%> (-100%)	⬇️
datalad/local/tests/test_subdataset.py	0% <0%> (-100%)	⬇️
datalad/support/tests/test_ansi_colors.py	0% <0%> (-100%)	⬇️
... and 220 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e335c...24a99f0. Read the comment docs.

[codecov]

Codecov Report

Merging #3622 into master will decrease coverage by 58.07%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master    #3622       +/-   ##
===========================================
- Coverage   82.93%   24.85%   -58.08%     
===========================================
  Files         273      270        -3     
  Lines       35509    35492       -17     
===========================================
- Hits        29450     8823    -20627     
- Misses       6059    26669    +20610

Impacted Files	Coverage Δ
datalad/downloaders/s3.py	0% <0%> (-57.37%)	⬇️
datalad/downloaders/http.py	0% <0%> (-61.51%)	⬇️
datalad/downloaders/base.py	0% <0%> (-56.37%)	⬇️
datalad/customremotes/tests/__init__.py	0% <0%> (-100%)	⬇️
datalad/tests/test_protocols.py	0% <0%> (-100%)	⬇️
datalad/tests/test_constraints.py	0% <0%> (-100%)	⬇️
datalad/tests/test_misc.py	0% <0%> (-100%)	⬇️
datalad/distribution/tests/test_clone.py	0% <0%> (-100%)	⬇️
datalad/local/tests/test_subdataset.py	0% <0%> (-100%)	⬇️
datalad/support/tests/test_ansi_colors.py	0% <0%> (-100%)	⬇️
... and 220 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e335c...8d1a72e. Read the comment docs.

[mih]

@kyleam Thx, I almost had it edited myself, almost... ;-)

[kyleam]

Thx, I almost had it edited myself, almost... ;-)

No problem. Those were caught by the tests, but I spotted one more. Pushing shortly.

[kyleam]

Some Travis runs failed with network issues. Restarted.

Edit: Actually, I guess not network issues:

+sudo apt-get update -qq
E: Failed to fetch http://apt.postgresql.org/pub/repos/apt/dists/xenial-pgdg/main/binary-i386/Packages  Writing more data than expected (788347 > 787357)

The restarted runs have failed as well. Given that AppVeyor and many of the main Travis runs passed, I think these setup failures shouldn't hold up this PR.

[mih]

Thx!