-
Notifications
You must be signed in to change notification settings - Fork 113
Fix gh-3621 broken error handling under PY3 #3622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mere move, indent, reformat.
Formerly exceptions had been imported blindly into downloaders.base There seems to be no advantage of having 'import *' at the core, and then specific imports downstream.
These locations were missed by the last commit.
Codecov Report
@@ Coverage Diff @@
## master #3622 +/- ##
===========================================
- Coverage 82.93% 24.85% -58.08%
===========================================
Files 273 270 -3
Lines 35509 35492 -17
===========================================
- Hits 29450 8823 -20627
- Misses 6059 26669 +20610
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3622 +/- ##
===========================================
- Coverage 82.93% 24.85% -58.08%
===========================================
Files 273 270 -3
Lines 35509 35492 -17
===========================================
- Hits 29450 8823 -20627
- Misses 6059 26669 +20610
Continue to review full report at Codecov.
|
This one was missed in 22392dd (RF: Discontinue evil 'import *', 2019-08-26).
@kyleam Thx, I almost had it edited myself, almost... ;-) |
No problem. Those were caught by the tests, but I spotted one more. Pushing shortly. |
As of bd975a8, this code is under the AccessDeniedError exception handling, so the access_denied flag is no longer needed.
Some Travis runs failed with network issues. Restarted. Edit: Actually, I guess not network issues:
The restarted runs have failed as well. Given that AppVeyor and many of the main Travis runs passed, I think these setup failures shouldn't hold up this PR. |
Thx! |
Pretty much just moving the affected code (see #3621). Plus replacement of
import *
usage.Fingers crossed...