Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH+TST: cfg_yoda will commit selectively and fail on dirty #3680

Merged
merged 1 commit into from Sep 16, 2019

Conversation

mih
Copy link
Member

@mih mih commented Sep 16, 2019

Before it would save the entire state of a dataset. Fixes #3666

Adjust and extend tests to cover the new behavior.

…taladgh-3666)

Before it would save the entire state of a dataset.

Adjust and extend tests to cover the new behavior.
@mih
Copy link
Member Author

@mih mih commented Sep 16, 2019

Unreleated appveyor failure.

ds.pathobj / '.gitattributes',
]

dirty = [
Copy link
Member

@yarikoptic yarikoptic Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it probably doesn't matter either way, but IMHO better to use generators more to gain some efficiency. E.g. making here it into a (), and below condition into if any(dirty):

Copy link
Member Author

@mih mih Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but wouldn't the generator be consumed by any() and leave me no info to put in the exception?

Copy link
Member

@yarikoptic yarikoptic Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right. sorry I have missed that it was used below! Sorry for the noise, disregard original comment ;)

kyleam
kyleam approved these changes Sep 16, 2019
@mih
Copy link
Member Author

@mih mih commented Sep 16, 2019

OK, let's move. Thx!

@mih mih merged commit e0047fe into datalad:master Sep 16, 2019
2 of 3 checks passed
@mih mih deleted the bf-yoda branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants