Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Config override spec sanity checks (fixes gh-3451) #3695

Merged
merged 2 commits into from Sep 22, 2019

Conversation

mih
Copy link
Member

@mih mih commented Sep 20, 2019

To prevent us from shooting ourselves in the foot. Without
this change, we could have specified section-less variables
that our own ConfigManager cannot handle, and don't seem to
be supported by Git either.

To prevent us from shooting ourselves in the foot. Without
this change, we could have specified section-less variables
that our own ConfigManager cannot handle, and don't seem to
be supported by Git either.
@codecov
Copy link

@codecov codecov bot commented Sep 20, 2019

Codecov Report

Merging #3695 into master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3695      +/-   ##
==========================================
- Coverage   82.88%   82.85%   -0.04%     
==========================================
  Files         273      274       +1     
  Lines       35797    35826      +29     
==========================================
+ Hits        29670    29683      +13     
- Misses       6127     6143      +16
Impacted Files Coverage Δ
datalad/cmdline/main.py 77.73% <66.66%> (-0.29%) ⬇️
datalad/auto.py 86.12% <0%> (-1.82%) ⬇️
datalad/downloaders/tests/test_http.py 60% <0%> (-1.24%) ⬇️
datalad/support/lzma.py 60% <0%> (ø)
datalad/tests/test_auto.py 88.62% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1565ec5...3797ac8. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Sep 22, 2019

Second appveyor run times out -- unlikely to be related to this change.

@mih mih merged commit c7aa628 into datalad:master Sep 22, 2019
2 of 3 checks passed
@mih mih deleted the bf-cfgoverrides branch Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant