Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code, trim deps on GitPy #3702

Merged
merged 4 commits into from Sep 24, 2019
Merged

Remove obsolete code, trim deps on GitPy #3702

merged 4 commits into from Sep 24, 2019

Conversation

mih
Copy link
Member

@mih mih commented Sep 23, 2019

  • remove Repo.is_submodule_modified()
  • remove GitRepo._get_added_files_commit_msg()
  • strip GitPy from
    • GitRepo.get_indexed_files()
    • GitRepo.get_files()

@codecov
Copy link

@codecov codecov bot commented Sep 23, 2019

Codecov Report

Merging #3702 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3702      +/-   ##
==========================================
- Coverage   82.87%   82.84%   -0.03%     
==========================================
  Files         273      273              
  Lines       35809    35794      -15     
==========================================
- Hits        29677    29655      -22     
- Misses       6132     6139       +7
Impacted Files Coverage Δ
datalad/support/tests/test_gitrepo.py 99.88% <ø> (-0.01%) ⬇️
datalad/support/gitrepo.py 84.52% <100%> (+0.03%) ⬆️
datalad/downloaders/tests/test_http.py 57.77% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc40d26...c97d103. Read the comment docs.

kyleam
kyleam approved these changes Sep 23, 2019
Copy link
Contributor

@kyleam kyleam left a comment

Thanks. LGTM.

@mih
Copy link
Member Author

@mih mih commented Sep 24, 2019

Thx

@mih mih merged commit 0050f09 into datalad:master Sep 24, 2019
2 of 3 checks passed
@mih mih deleted the rf-obsolete branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants